| Message ID | 20200625080430.1392037-2-maxime.coquelin@redhat.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | rte_dev_probe() API change | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-nxp-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/checkpatch | success | coding style OK |
Hi Thomas, Davis, On 6/25/20 10:04 AM, Maxime Coquelin wrote: > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d1034f60fd..8661a673b5 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -130,3 +130,8 @@ Deprecation Notices > Python 2 support will be completely removed in 20.11. > In 20.08, explicit deprecation warnings will be displayed when running > scripts with Python 2. > + > +* eal: Change ``rte_dev_probe`` API in DPDK v20.11 to return a pointer on the > + probed rte_device or NULL instead of 0 or an error code. This change will > + allow applications avoid iterating on devices after a probe to get access to > + the new rte_device. > Any chance this patch goes into -rc4? Patch 2 is for v20.11, but we would need the deprecation notice to be in v20.08. Thanks, Maxime
On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On 31/07/20 10:26 +0100, Bruce Richardson wrote: > On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: > > In order to simplify the use of rte_dev_probe() and > > rte_dev_remove() by applications, rte_dev_probe() will > > return a reference on the rte_device stating DPDK v20.11. > > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > --- > Acked-by: Bruce Richardson <bruce.richardson@intel.com> I don't remember if I acked the reworded version, in anycase Acked-by: Gaetan Rivet <grive@u256.net>
On 7/31/20 11:44 AM, Gaëtan Rivet wrote: > On 31/07/20 10:26 +0100, Bruce Richardson wrote: >> On Thu, Jun 25, 2020 at 10:04:29AM +0200, Maxime Coquelin wrote: >>> In order to simplify the use of rte_dev_probe() and >>> rte_dev_remove() by applications, rte_dev_probe() will >>> return a reference on the rte_device stating DPDK v20.11. s/stating/starting/ >>> >>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> >>> --- >> Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > I don't remember if I acked the reworded version, in anycase > Acked-by: Gaetan Rivet <grive@u256.net> > No you didn't, but I didn't replied to your comment on patch 2, so you are forgiven :) Thanks! Maxime
On Thu, Jun 25, 2020 at 10:04 AM Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: David Marchand <david.marchand@redhat.com>
On Tue, Aug 4, 2020 at 1:42 PM David Marchand <david.marchand@redhat.com> wrote: > > On Thu, Jun 25, 2020 at 10:04 AM Maxime Coquelin > <maxime.coquelin@redhat.com> wrote: > > > > In order to simplify the use of rte_dev_probe() and > > rte_dev_remove() by applications, rte_dev_probe() will > > return a reference on the rte_device stating DPDK v20.11. > > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Acked-by: David Marchand <david.marchand@redhat.com> Acked-by: Jerin Jacob <jerinj@marvell.com> > > > -- > David Marchand >
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index d1034f60fd..8661a673b5 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -130,3 +130,8 @@ Deprecation Notices Python 2 support will be completely removed in 20.11. In 20.08, explicit deprecation warnings will be displayed when running scripts with Python 2. + +* eal: Change ``rte_dev_probe`` API in DPDK v20.11 to return a pointer on the + probed rte_device or NULL instead of 0 or an error code. This change will + allow applications avoid iterating on devices after a probe to get access to + the new rte_device.
In order to simplify the use of rte_dev_probe() and rte_dev_remove() by applications, rte_dev_probe() will return a reference on the rte_device stating DPDK v20.11. Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+)