diff mbox series

net/ice: set max frame size

Message ID 20191024190818.36524-1-jiaqix.min@intel.com (mailing list archive)
State Superseded, archived
Delegated to: xiaolong ye
Headers
Series net/ice: set max frame size |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Min, JiaqiX Oct. 24, 2019, 7:08 p.m. UTC 
Max frame size is not set to HW, so packets above the MTU
do not get dropped by HW. The patch fixed the issue.

Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Xiaolong Ye Oct. 25, 2019, 3:06 a.m. UTC | #1 
Hi,

Could you provide the Fixes tag and cc stable?

Thanks,
Xiaolong

On 10/24, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>---
> drivers/net/ice/ice_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 022b58c01..403305cfb 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
> 
> 	pf->adapter_stopped = false;
> 
>+	/* Set the max frame size */
>+	ice_aq_set_mac_cfg(hw,
>+		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>+
> 	return 0;
> 
> 	/* stop the started queues if failed to start all queues */
>-- 
>2.17.1
>
Min, JiaqiX Oct. 25, 2019, 3:39 a.m. UTC | #2 
Hi Xiaolong, 

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Friday, October 25, 2019 11:06 AM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size
> 
> Hi,
> 
> Could you provide the Fixes tag and cc stable?
>
 
It's a persistent issue,  maybe  it is an implementation miss.
So  Fixes tag can't be provided.  Like this,  need cc stable?

> Thanks,
> 
> 
> On 10/24, Min JiaqiX wrote:
> >Max frame size is not set to HW, so packets above the MTU do not get
> >dropped by HW. The patch fixed the issue.
> >
> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >---
> > drivers/net/ice/ice_ethdev.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
> >
> > 	pf->adapter_stopped = false;
> >
> >+	/* Set the max frame size */
> >+	ice_aq_set_mac_cfg(hw,
> >+		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
> >+
> > 	return 0;
> >
> > 	/* stop the started queues if failed to start all queues */
> >--
> >2.17.1
> >
Kevin Traynor Oct. 25, 2019, 9:43 a.m. UTC | #3 
On 25/10/2019 04:39, Min, JiaqiX wrote:
> Hi Xiaolong, 
> 
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, October 25, 2019 11:06 AM
>> To: Min, JiaqiX <jiaqix.min@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size
>>
>> Hi,
>>
>> Could you provide the Fixes tag and cc stable?
>>
>  
> It's a persistent issue,  maybe  it is an implementation miss.
> So  Fixes tag can't be provided.  Like this,  need cc stable?
> 

If it is an implementation miss since the driver was written then please
set the Fixes tag to the commit where the driver was introduced.

>> Thanks,
>>
>>
>> On 10/24, Min JiaqiX wrote:
>>> Max frame size is not set to HW, so packets above the MTU do not get
>>> dropped by HW. The patch fixed the issue.
>>>
>>> Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>>> ---
>>> drivers/net/ice/ice_ethdev.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/net/ice/ice_ethdev.c
>>> b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
>>> --- a/drivers/net/ice/ice_ethdev.c
>>> +++ b/drivers/net/ice/ice_ethdev.c
>>> @@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>>>
>>> 	pf->adapter_stopped = false;
>>>
>>> +	/* Set the max frame size */
>>> +	ice_aq_set_mac_cfg(hw,
>>> +		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>>> +
>>> 	return 0;
>>>
>>> 	/* stop the started queues if failed to start all queues */
>>> --
>>> 2.17.1
>>>
Xiaolong Ye Oct. 28, 2019, 5:29 a.m. UTC | #4 
Hi, Jiaqi

On 10/25, Min, JiaqiX wrote:
>Hi Xiaolong, 
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, October 25, 2019 11:06 AM
>> To: Min, JiaqiX <jiaqix.min@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size
>> 
>> Hi,
>> 
>> Could you provide the Fixes tag and cc stable?
>>
> 
>It's a persistent issue,  maybe  it is an implementation miss.
>So  Fixes tag can't be provided.  Like this,  need cc stable?

I think in this case, the fix tag could be the first commit that introduced
icd driver.

Thanks,
Xiaolong



>
>> Thanks,
>> 
>> 
>> On 10/24, Min JiaqiX wrote:
>> >Max frame size is not set to HW, so packets above the MTU do not get
>> >dropped by HW. The patch fixed the issue.
>> >
>> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>> >---
>> > drivers/net/ice/ice_ethdev.c | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> >diff --git a/drivers/net/ice/ice_ethdev.c
>> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
>> >--- a/drivers/net/ice/ice_ethdev.c
>> >+++ b/drivers/net/ice/ice_ethdev.c
>> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>> >
>> > 	pf->adapter_stopped = false;
>> >
>> >+	/* Set the max frame size */
>> >+	ice_aq_set_mac_cfg(hw,
>> >+		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>> >+
>> > 	return 0;
>> >
>> > 	/* stop the started queues if failed to start all queues */
>> >--
>> >2.17.1
>> >
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 022b58c01..403305cfb 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2506,6 +2506,10 @@  ice_dev_start(struct rte_eth_dev *dev)
 
 	pf->adapter_stopped = false;
 
+	/* Set the max frame size */
+	ice_aq_set_mac_cfg(hw,
+		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
+
 	return 0;
 
 	/* stop the started queues if failed to start all queues */