diff mbox series

raw/ioat: fix compiler warning for incorrect include

Message ID 20190723162648.15217-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Headers
Series raw/ioat: fix compiler warning for incorrect include |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Bruce Richardson July 23, 2019, 4:26 p.m. UTC 
  Some builds with clang report an error because '<>' rather than '""' were
used for including the ioat spec header file.

  Target: x86_64-native-bsdapp-clang
  22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
  #include <rte_ioat_spec.h>
           ^~~~~~~~~~~~~~~~~
           "rte_ioat_spec.h"
  1 error generated.

Since this file should always be in the same directory as the main header,
we can safely change the include line to fix this error.

Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/raw/ioat/rte_ioat_rawdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon July 23, 2019, 6:51 p.m. UTC | #1 
23/07/2019 18:26, Bruce Richardson:
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
> 
>   Target: x86_64-native-bsdapp-clang
>   22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
>   #include <rte_ioat_spec.h>
>            ^~~~~~~~~~~~~~~~~
>            "rte_ioat_spec.h"
>   1 error generated.
> 
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
> 
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
David Marchand July 23, 2019, 6:53 p.m. UTC | #2 
On Tue, Jul 23, 2019 at 6:27 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
>
>   Target: x86_64-native-bsdapp-clang
>   22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
>   #include <rte_ioat_spec.h>
>            ^~~~~~~~~~~~~~~~~
>            "rte_ioat_spec.h"
>   1 error generated.
>
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
>
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Still a bit skeptical at why we did not see this on linux..
But this can't hurt and hopefully it fixes the issue :-)

Reviewed-by: David Marchand <david.marchand@redhat.com>
diff mbox series

Patch

diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h
index 7a89632e7..4b271f174 100644
--- a/drivers/raw/ioat/rte_ioat_rawdev.h
+++ b/drivers/raw/ioat/rte_ioat_rawdev.h
@@ -19,7 +19,7 @@ 
 #include <rte_memory.h>
 #include <rte_memzone.h>
 #include <rte_prefetch.h>
-#include <rte_ioat_spec.h>
+#include "rte_ioat_spec.h"
 
 /** Name of the device driver */
 #define IOAT_PMD_RAWDEV_NAME rawdev_ioat