diff mbox series

app/testpmd: fix MAC addr parser for flow

Message ID 20190722165832.38054-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series app/testpmd: fix MAC addr parser for flow | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Ferruh Yigit July 22, 2019, 4:58 p.m. UTC
MAC address parsing was causing failure [1],
this patch partially reverts the commit
commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")

[1]
testpmd> flow validate 0  priority  2 ingress group 0 pattern eth dst
is 98:03:9B:5C:D9:00 / end actions queue index  0 / end
Bad arguments

Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")

Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test-pmd/cmdline_flow.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit July 22, 2019, 5:02 p.m. UTC | #1
On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> MAC address parsing was causing failure [1],
> this patch partially reverts the commit
> commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> 
> [1]
> testpmd> flow validate 0  priority  2 ingress group 0 pattern eth dst
> is 98:03:9B:5C:D9:00 / end actions queue index  0 / end
> Bad arguments
> 
> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> 
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Stephen Hemminger <stephen@networkplumber.org>

If there is no objection, or more proper fix, till tomorrow morning (europe
time), I am planning to merge this one, fyi.
Ferruh Yigit July 22, 2019, 5:17 p.m. UTC | #2
On 7/22/2019 6:02 PM, Ferruh Yigit wrote:
> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
>> MAC address parsing was causing failure [1],
>> this patch partially reverts the commit
>> commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>
>> [1]
>> testpmd> flow validate 0  priority  2 ingress group 0 pattern eth dst
>> is 98:03:9B:5C:D9:00 / end actions queue index  0 / end
>> Bad arguments
>>
>> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>
>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Stephen Hemminger <stephen@networkplumber.org>
> 
> If there is no objection, or more proper fix, till tomorrow morning (europe
> time), I am planning to merge this one, fyi.
> 

+cc Thomas
Stephen Hemminger July 22, 2019, 5:20 p.m. UTC | #3
On Mon, 22 Jul 2019 18:02:09 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> > MAC address parsing was causing failure [1],
> > this patch partially reverts the commit
> > commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> > 
> > [1]  
> > testpmd> flow validate 0  priority  2 ingress group 0 pattern eth dst  
> > is 98:03:9B:5C:D9:00 / end actions queue index  0 / end
> > Bad arguments
> > 
> > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> > 
> > Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Cc: Stephen Hemminger <stephen@networkplumber.org>  
> 
> If there is no objection, or more proper fix, till tomorrow morning (europe
> time), I am planning to merge this one, fyi.

Works for me, testpmd always has the cmdline library anyway.
Raslan Darawsheh July 23, 2019, 6:39 a.m. UTC | #4
Tested-by: Raslan Darawsheh <rasland@mellanox.com>
Seems OK for me, 

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, July 22, 2019 8:20 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
> 
> On Mon, 22 Jul 2019 18:02:09 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> > > MAC address parsing was causing failure [1], this patch partially
> > > reverts the commit commit b5ddce8959b2 ("app/testpmd: use new
> > > ethernet address parser")
> > >
> > > [1]
> > > testpmd> flow validate 0  priority  2 ingress group 0 pattern eth
> > > testpmd> dst
> > > is 98:03:9B:5C:D9:00 / end actions queue index  0 / end Bad
> > > arguments
> > >
> > > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> > >
> > > Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> > > Cc: Stephen Hemminger <stephen@networkplumber.org>
> >
> > If there is no objection, or more proper fix, till tomorrow morning
> > (europe time), I am planning to merge this one, fyi.
> 
> Works for me, testpmd always has the cmdline library anyway.
Ferruh Yigit July 23, 2019, 10:42 a.m. UTC | #5
On 7/23/2019 7:39 AM, Raslan Darawsheh wrote:
> Tested-by: Raslan Darawsheh <rasland@mellanox.com>
> Seems OK for me, 
> 
> Kindest regards,
> Raslan Darawsheh
> 
>> -----Original Message-----
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Sent: Monday, July 22, 2019 8:20 PM
>> To: Ferruh Yigit <ferruh.yigit@intel.com>
>> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Wenzhuo Lu
>> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
>> Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; Raslan
>> Darawsheh <rasland@mellanox.com>
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
>>
>> On Mon, 22 Jul 2019 18:02:09 +0100
>> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>>> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
>>>> MAC address parsing was causing failure [1], this patch partially
>>>> reverts the commit commit b5ddce8959b2 ("app/testpmd: use new
>>>> ethernet address parser")
>>>>
>>>> [1]
>>>> testpmd> flow validate 0  priority  2 ingress group 0 pattern eth
>>>> testpmd> dst
>>>> is 98:03:9B:5C:D9:00 / end actions queue index  0 / end Bad
>>>> arguments
>>>>
>>>> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>>>
>>>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> ---
>>>> Cc: Stephen Hemminger <stephen@networkplumber.org>
>>>
>>> If there is no objection, or more proper fix, till tomorrow morning
>>> (europe time), I am planning to merge this one, fyi.
>>
>> Works for me, testpmd always has the cmdline library anyway.

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index d08f016be..495871394 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -18,6 +18,7 @@ 
 #include <rte_ethdev.h>
 #include <rte_byteorder.h>
 #include <cmdline_parse.h>
+#include <cmdline_parse_etheraddr.h>
 #include <rte_flow.h>
 
 #include "testpmd.h"
@@ -4978,8 +4979,8 @@  parse_mac_addr(struct context *ctx, const struct token *token,
 	/* Only network endian is supported. */
 	if (!arg->hton)
 		goto error;
-	ret = rte_ether_unformat_addr(str, &tmp);
-	if (ret < 0)
+	ret = cmdline_parse_etheraddr(NULL, str, &tmp, size);
+	if (ret < 0 || (unsigned int)ret != len)
 		goto error;
 	if (!ctx->object)
 		return len;