diff mbox series

[5/7] net/bnxt: disable vector mode Tx with VLAN offload

Message ID 20190719061906.42451-6-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series bnxt patches |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Ajit Khaparde July 19, 2019, 6:19 a.m. UTC 
  From: Lance Richardson <lance.richardson@broadcom.com>

The vector mode transmit path does not currently support VLAN tag
insertion, so we need to disable vector transmit when transmit
VLAN insertion offload is enabled.

Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index fec1ecbae..d6176a686 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -743,13 +743,11 @@  bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev)
 {
 #ifdef RTE_ARCH_X86
 	/*
-	 * Vector mode receive can be enabled only if scatter tx is not
-	 * in use and tx offloads other than VLAN insertion are not
-	 * in use.
+	 * Vector mode transmit can be enabled only if not using scatter rx
+	 * or tx offloads.
 	 */
 	if (!eth_dev->data->scattered_rx &&
-	    !(eth_dev->data->dev_conf.txmode.offloads &
-	      ~DEV_TX_OFFLOAD_VLAN_INSERT)) {
+	    !eth_dev->data->dev_conf.txmode.offloads) {
 		PMD_DRV_LOG(INFO, "Using vector mode transmit for port %d\n",
 			    eth_dev->data->port_id);
 		return bnxt_xmit_pkts_vec;