net/netvsc: fix definition of offload values

Message ID 20190703155001.23244-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/netvsc: fix definition of offload values |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Stephen Hemminger July 3, 2019, 3:50 p.m. UTC
  The definition of ipsec and rsc offloads was incorrect.
Neither one of these is used by current driver, but the values
should be fixed now for future RSC support.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/ndis.h | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)
  

Comments

Ferruh Yigit July 4, 2019, 4:42 p.m. UTC | #1
On 7/3/2019 4:50 PM, Stephen Hemminger wrote:
> The definition of ipsec and rsc offloads was incorrect.
> Neither one of these is used by current driver, but the values
> should be fixed now for future RSC support.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/netvsc/ndis.h b/drivers/net/netvsc/ndis.h
index 2e7ca99b151f..d97a397a8604 100644
--- a/drivers/net/netvsc/ndis.h
+++ b/drivers/net/netvsc/ndis.h
@@ -262,17 +262,17 @@  struct ndis_lsov2_offload {
 
 struct ndis_ipsecv2_offload {
 	uint32_t			ndis_encap;	/*NDIS_OFFLOAD_ENCAP_*/
-	uint16_t			ndis_ip6;
-	uint16_t			ndis_ip4opt;
-	uint16_t			ndis_ip6ext;
-	uint16_t			ndis_ah;
-	uint16_t			ndis_esp;
-	uint16_t			ndis_ah_esp;
-	uint16_t			ndis_xport;
-	uint16_t			ndis_tun;
-	uint16_t			ndis_xport_tun;
-	uint16_t			ndis_lso;
-	uint16_t			ndis_extseq;
+	uint8_t				ndis_ip6;
+	uint8_t				ndis_ip4opt;
+	uint8_t				ndis_ip6ext;
+	uint8_t				ndis_ah;
+	uint8_t				ndis_esp;
+	uint8_t				ndis_ah_esp;
+	uint8_t				ndis_xport;
+	uint8_t				ndis_tun;
+	uint8_t				ndis_xport_tun;
+	uint8_t				ndis_lso;
+	uint8_t				ndis_extseq;
 	uint32_t			ndis_udp_esp;
 	uint32_t			ndis_auth;
 	uint32_t			ndis_crypto;
@@ -280,8 +280,8 @@  struct ndis_ipsecv2_offload {
 };
 
 struct ndis_rsc_offload {
-	uint16_t			ndis_ip4;
-	uint16_t			ndis_ip6;
+	uint8_t				ndis_ip4;
+	uint8_t				ndis_ip6;
 };
 
 struct ndis_encap_offload {