diff mbox series

eal: remove unnecessary dirent.h include

Message ID 20181214164000.9667-1-jeffrey.b.shaw@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series eal: remove unnecessary dirent.h include | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Jeff Shaw Dec. 14, 2018, 4:40 p.m. UTC
Prior to this patch, the two affected .c files include <dirent.h>
unnecessarily. This commit removes the include lines.

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
 lib/librte_eal/common/eal_common_lcore.c | 1 -
 lib/librte_eal/common/rte_service.c      | 1 -
 2 files changed, 2 deletions(-)

Comments

Rami Rosen Dec. 17, 2018, 3:42 p.m. UTC | #1
Reviewed-by: Rami Rosen <ramirose@gmail.com>

On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Prior to this patch, the two affected .c files include <dirent.h>
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
>  lib/librte_eal/common/eal_common_lcore.c | 1 -
>  lib/librte_eal/common/rte_service.c      | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
> index 3167e9d79..1cbac4228 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -5,7 +5,6 @@
>  #include <unistd.h>
>  #include <limits.h>
>  #include <string.h>
> -#include <dirent.h>
>
>  #include <rte_errno.h>
>  #include <rte_log.h>
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 0f3695c4b..03fde97a9 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -7,7 +7,6 @@
>  #include <inttypes.h>
>  #include <limits.h>
>  #include <string.h>
> -#include <dirent.h>
>
>  #include <rte_compat.h>
>  #include <rte_service.h>
> --
> 2.14.3
>
Ferruh Yigit Dec. 17, 2018, 11:58 p.m. UTC | #2
On 12/17/2018 3:42 PM, Rami Rosen wrote:

> On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>>
>> Prior to this patch, the two affected .c files include <dirent.h>
>> unnecessarily. This commit removes the include lines.
>>
>> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Dec. 19, 2018, 12:30 a.m. UTC | #3
18/12/2018 00:58, Ferruh Yigit:
> On 12/17/2018 3:42 PM, Rami Rosen wrote:
> > On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
> >>
> >> Prior to this patch, the two affected .c files include <dirent.h>
> >> unnecessarily. This commit removes the include lines.
> >>
> >> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> >
> > Reviewed-by: Rami Rosen <ramirose@gmail.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
index 3167e9d79..1cbac4228 100644
--- a/lib/librte_eal/common/eal_common_lcore.c
+++ b/lib/librte_eal/common/eal_common_lcore.c
@@ -5,7 +5,6 @@ 
 #include <unistd.h>
 #include <limits.h>
 #include <string.h>
-#include <dirent.h>
 
 #include <rte_errno.h>
 #include <rte_log.h>
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 0f3695c4b..03fde97a9 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -7,7 +7,6 @@ 
 #include <inttypes.h>
 #include <limits.h>
 #include <string.h>
-#include <dirent.h>
 
 #include <rte_compat.h>
 #include <rte_service.h>