diff mbox series

[v6,1/9] app/procinfo: add usage for new debug

Message ID 20181203055000.39012-2-vipin.varghese@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series app/proc-info: improve debug of proc-info tool | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Varghese, Vipin Dec. 3, 2018, 5:49 a.m. UTC
Update the file with MACRO for stats border, usage text information
and string comparision.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---

V6:
 - add mempool iterate elements option - Vipin Varghese

V3:
 - change the usage details - Vipin Varghese

V2:
 - change word dbg to show - Stephen Hemminger
---
 app/proc-info/main.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Comments

Pattan, Reshma Dec. 12, 2018, 2:14 p.m. UTC | #1
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, December 3, 2018 5:50 AM
> Subject: [PATCH v6 1/9] app/procinfo: add usage for new debug
> 
> @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname)
>  		"  --stats-reset: to reset port statistics\n"
>  		"  --xstats-reset: to reset port extended statistics\n"
>  		"  --collectd-format: to print statistics to STDOUT in expected by
> collectd format\n"
> -		"  --host-id STRING: host id used to identify the system process
> is running on\n",
> +		"  --host-id STRING: host id used to identify the system process
> is running on\n"
> +		"  --show-port to display ports information\n"
> +		"  --show-tm to display traffic manager information for ports\n"
> +		"  --show-crypto to display crypto information\n"
> +		"  --show-ring[=name] to display ring information\n"
> +		"  --show-mempool[=name] to display mempool information\n"
> +		"  --iter-mempool=name to iterate mempool elements\n",
>  		prgname);
>  }
> 

Style related comment, add ' :'  between  command token  and token message, similar to host-id and other .

Is iter-mempool option, only to iterate only or to display the elements also? Then update the help message.

Thanks,
Reshma
Varghese, Vipin Dec. 12, 2018, 3:06 p.m. UTC | #2
> > @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname)
> >  		"  --stats-reset: to reset port statistics\n"
> >  		"  --xstats-reset: to reset port extended statistics\n"
> >  		"  --collectd-format: to print statistics to STDOUT in expected
> by
> > collectd format\n"
> > -		"  --host-id STRING: host id used to identify the system process
> > is running on\n",
> > +		"  --host-id STRING: host id used to identify the system process
> > is running on\n"
> > +		"  --show-port to display ports information\n"
> > +		"  --show-tm to display traffic manager information for
> ports\n"
> > +		"  --show-crypto to display crypto information\n"
> > +		"  --show-ring[=name] to display ring information\n"
> > +		"  --show-mempool[=name] to display mempool
> information\n"
> > +		"  --iter-mempool=name to iterate mempool elements\n",
> >  		prgname);
> >  }
> >
> 
> Style related comment, add ' :'  between  command token  and token message,
> similar to host-id and other .
> 
> Is iter-mempool option, only to iterate only or to display the elements also?
> Then update the help message.

Thanks for sharing this thought, I am clear with the idea this does not convey the complete required message as explained 'Patch 9/9'. Hence I am ready to reword as ""  --iter-mempool=name: to iterate mempool elements and display content\n "
> 
> Thanks,
> Reshma
diff mbox series

Patch

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index c20effa4f..c034aad97 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -36,6 +36,10 @@ 
 
 #define MAX_STRING_LEN 256
 
+#define STATS_BDR_FMT "========================================"
+#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \
+	STATS_BDR_FMT, s, w, STATS_BDR_FMT)
+
 /**< mask of enabled ports */
 static uint32_t enabled_port_mask;
 /**< Enable stats. */
@@ -83,7 +87,13 @@  proc_info_usage(const char *prgname)
 		"  --stats-reset: to reset port statistics\n"
 		"  --xstats-reset: to reset port extended statistics\n"
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
-		"  --host-id STRING: host id used to identify the system process is running on\n",
+		"  --host-id STRING: host id used to identify the system process is running on\n"
+		"  --show-port to display ports information\n"
+		"  --show-tm to display traffic manager information for ports\n"
+		"  --show-crypto to display crypto information\n"
+		"  --show-ring[=name] to display ring information\n"
+		"  --show-mempool[=name] to display mempool information\n"
+		"  --iter-mempool=name to iterate mempool elements\n",
 		prgname);
 }
 
@@ -190,6 +200,12 @@  proc_info_parse_args(int argc, char **argv)
 		{"collectd-format", 0, NULL, 0},
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
+		{"show-port", 0, NULL, 0},
+		{"show-tm", 0, NULL, 0},
+		{"show-crypto", 0, NULL, 0},
+		{"show-ring", optional_argument, NULL, 0},
+		{"show-mempool", optional_argument, NULL, 0},
+		{"iter-mempool", required_argument, NULL, 0},
 		{NULL, 0, 0, 0}
 	};