diff mbox series

doc: update commands for pdump

Message ID 20181122025138.31824-1-tiwei.bie@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc: update commands for pdump |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Tiwei Bie Nov. 22, 2018, 2:51 a.m. UTC 
  The --server-socket-path and --client-socket-path options
have already been removed. So also remove them from the doc
to avoid confusion.

Fixes: 09f4aa2b955f ("app/pdump: remove unused socket path options")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 doc/guides/tools/pdump.rst | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Ferruh Yigit Nov. 22, 2018, 4:36 p.m. UTC | #1 
On 11/22/2018 2:51 AM, Tiwei Bie wrote:
> The --server-socket-path and --client-socket-path options
> have already been removed. So also remove them from the doc
> to avoid confusion.
> 
> Fixes: 09f4aa2b955f ("app/pdump: remove unused socket path options")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
John McNamara Nov. 22, 2018, 5:54 p.m. UTC | #2 
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Thursday, November 22, 2018 2:52 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] doc: update commands for pdump
> 
> The --server-socket-path and --client-socket-path options have already
> been removed. So also remove them from the doc to avoid confusion.


Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon Nov. 25, 2018, 9:57 a.m. UTC | #3 
22/11/2018 18:54, Mcnamara, John:
> From: Bie, Tiwei
> > The --server-socket-path and --client-socket-path options have already
> > been removed. So also remove them from the doc to avoid confusion.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst
index 5168c81ab..7c2b73e72 100644
--- a/doc/guides/tools/pdump.rst
+++ b/doc/guides/tools/pdump.rst
@@ -42,8 +42,6 @@  The tool has a number of command line options:
                                    [ring-size=<ring size>],
                                    [mbuf-size=<mbuf data size>],
                                    [total-num-mbufs=<number of mbufs>]'
-                          [--server-socket-path=<server socket dir>]
-                          [--client-socket-path=<client socket dir>]
 
 The ``--pdump`` command line option is mandatory and it takes various sub arguments which are described in
 below section.
@@ -56,14 +54,6 @@  below section.
 
       * Multiple instances of ``--pdump`` can be passed to capture packets on different port and queue combinations.
 
-The ``--server-socket-path`` command line option is optional. This represents the server socket directory.
-If no value is passed default values are used i.e. ``/var/run/.dpdk/`` for root users and ``~/.dpdk/``
-for non root users.
-
-The ``--client-socket-path`` command line option is optional. This represents the client socket directory.
-If no value is passed default values are used i.e. ``/var/run/.dpdk/`` for root users and ``~/.dpdk/``
-for non root users.
-
 
 The ``--pdump`` parameters
 ~~~~~~~~~~~~~~~~~~~~~~~~~~