crypto/aesni_gcm: remove unneeded J0 calculation
Checks
Commit Message
When IV size is 12, padding to 16 bytes is required
and the LSB must be set to 1, according to the spec.
However, the Multi-buffer library is already doing this,
so it is not necessary to do it in the PMD.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 9 ---------
1 file changed, 9 deletions(-)
Comments
> When IV size is 12, padding to 16 bytes is required and the LSB must be set to
> 1, according to the spec.
> However, the Multi-buffer library is already doing this, so it is not necessary
> to do it in the PMD.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
On 8/14/2018 6:23 AM, Pablo de Lara wrote:
> When IV size is 12, padding to 16 bytes is required
> and the LSB must be set to 1, according to the spec.
> However, the Multi-buffer library is already doing this,
> so it is not necessary to do it in the PMD.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
Applied to dpdk-next-crypto
Thanks
@@ -240,17 +240,8 @@ process_gcm_crypto_op(struct aesni_gcm_qp *qp, struct rte_crypto_op *op,
iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
session->iv.offset);
- /*
- * GCM working in 12B IV mode => 16B pre-counter block we need
- * to set BE LSB to 1, driver expects that 16B is allocated
- */
- if (session->iv.length == 12) {
- uint32_t *iv_padd = (uint32_t *)&(iv_ptr[12]);
- *iv_padd = rte_bswap32(1);
- }
if (session->op == AESNI_GCM_OP_AUTHENTICATED_ENCRYPTION) {
-
qp->ops[session->key].init(&session->gdata_key,
&qp->gdata_ctx,
iv_ptr,