diff mbox series

[dpdk-dev,5/7] dpaa2: fix default IOVA build setting for meson builds

Message ID 20180608163807.66737-6-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series Enable 32-bit native builds with meson | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson June 8, 2018, 4:38 p.m. UTC
By default, the DPAA2_USE_PHYS_IOVA setting with the make build-system
is "y", which is overridden to "n" in the config file specifically for
the arm64-dpaa2-linuxapp-gcc builds. The lack of this setting in meson
builds causes issues for 32-bit build, as the alternative code paths
have compiler warnings e.g. for i686 builds. Therefore we should align
the meson and make settings, setting the value to "true" by default and
overriding it to "false" for dpaa2-specific builds.

Fixes: 6ec78c2463ac ("build: add meson support for dpaaX platforms")

Cc: hemant.agrawal@nxp.com
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/arm/meson.build | 2 +-
 config/meson.build     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Hemant Agrawal June 29, 2018, 8:52 a.m. UTC | #1
On 6/8/2018 10:08 PM, Bruce Richardson wrote:
> By default, the DPAA2_USE_PHYS_IOVA setting with the make build-system
> is "y", which is overridden to "n" in the config file specifically for
> the arm64-dpaa2-linuxapp-gcc builds. The lack of this setting in meson
> builds causes issues for 32-bit build, as the alternative code paths
> have compiler warnings e.g. for i686 builds. Therefore we should align
> the meson and make settings, setting the value to "true" by default and
> overriding it to "false" for dpaa2-specific builds.
>
> Fixes: 6ec78c2463ac ("build: add meson support for dpaaX platforms")
>
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 5ad926eda..40dbc87f7 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -64,7 +64,7 @@  flags_dpaa2 = [
 	['RTE_CACHE_LINE_SIZE', 64],
 	['RTE_MAX_NUMA_NODES', 1],
 	['RTE_MAX_LCORE', 16],
-	['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', 'n']]
+	['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
 
 ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)
 impl_generic = ['Generic armv8', flags_generic, machine_args_generic]
diff --git a/config/meson.build b/config/meson.build
index 1531d9f0e..7a84fa8d0 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -78,6 +78,7 @@  dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id
 # values which have defaults which may be overridden
 dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)
 dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64)
+dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true)
 
 compile_time_cpuflags = []
 if host_machine.cpu_family().startswith('x86')