[dpdk-dev] net/i40e: revert default PF PMD device name

Message ID 20180430153020.971-1-declan.doherty@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Doherty, Declan April 30, 2018, 3:30 p.m. UTC
  Changes introduced by e0cb96204b71 modified the default name generated
for the i40e PF PMD, this patch reverts the default name to the
original PCI BDBF.

Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-off-by: Declan Doherty <declan.doherty@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
  

Comments

Ferruh Yigit May 1, 2018, 3:41 p.m. UTC | #1
On 4/30/2018 4:30 PM, Declan Doherty wrote:
> Changes introduced by e0cb96204b71 modified the default name generated
> for the i40e PF PMD, this patch reverts the default name to the
> original PCI BDBF.
> 
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Ferruh Yigit May 1, 2018, 3:42 p.m. UTC | #2
On 5/1/2018 4:41 PM, Ferruh Yigit wrote:
> On 4/30/2018 4:30 PM, Declan Doherty wrote:
>> Changes introduced by e0cb96204b71 modified the default name generated
>> for the i40e PF PMD, this patch reverts the default name to the
>> original PCI BDBF.
>>
>> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index d869add95..284e9cb64 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -630,10 +630,7 @@  eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 			return retval;
 	}
 
-	/* physical port net_bdf_port */
-	snprintf(name, sizeof(name), "net_%s", pci_dev->device.name);
-
-	retval = rte_eth_dev_create(&pci_dev->device, name,
+	retval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,
 		sizeof(struct i40e_adapter),
 		eth_dev_pci_specific_init, pci_dev,
 		eth_i40e_dev_init, NULL);
@@ -642,7 +639,8 @@  eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 		return retval;
 
 	/* probe VF representor ports */
-	struct rte_eth_dev *pf_ethdev = rte_eth_dev_allocated(name);
+	struct rte_eth_dev *pf_ethdev = rte_eth_dev_allocated(
+		pci_dev->device.name);
 
 	if (pf_ethdev == NULL)
 		return -ENODEV;