diff mbox

[dpdk-dev] ethdev: fix link status query

Message ID 20180410061631.50301-1-shahafs@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shahaf Shuler April 10, 2018, 6:16 a.m. UTC 
  When application works with LSC interrupts the ethdev layer skips
the PMD callback and update according to the link status exists on
device data. It is because it assumes the link status on the device data
is the correct one since any link change is processed by the application.

As multiple PMDs install the link status interrupt handler only on port
start and uninstall it on port stop, the link status may be incorrect in
case the query is called after port stop or before port start.

Fixing the query implementation to use the PMD callback for such cases.

Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
Cc: stable@dpdk.org
Cc: stephen@networkplumber.org
Cc: nelio.laranjeiro@6wind.com

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 lib/librte_ether/rte_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Nélio Laranjeiro April 10, 2018, 8:20 a.m. UTC | #1 
On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
> When application works with LSC interrupts the ethdev layer skips
> the PMD callback and update according to the link status exists on
> device data. It is because it assumes the link status on the device data
> is the correct one since any link change is processed by the application.
> 
> As multiple PMDs install the link status interrupt handler only on port
> start and uninstall it on port stop, the link status may be incorrect in
> case the query is called after port stop or before port start.

It seems also logical to not process interrupts from stopped device,
for them accessing to the link status should always end by calling the
devop function.

This patch is the result of discussion on thread [1].

> Fixing the query implementation to use the PMD callback for such cases.
> 
> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
> Cc: stable@dpdk.org
> Cc: stephen@networkplumber.org
> Cc: nelio.laranjeiro@6wind.com

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 2c74f7e049..0857670ebe 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -1789,7 +1789,8 @@ rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
>  	RTE_ETH_VALID_PORTID_OR_RET(port_id);
>  	dev = &rte_eth_devices[port_id];
>  
> -	if (dev->data->dev_conf.intr_conf.lsc)
> +	if (dev->data->dev_conf.intr_conf.lsc &&
> +	    dev->data->dev_started)
>  		rte_eth_linkstatus_get(dev, eth_link);
>  	else {
>  		RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
> @@ -1806,7 +1807,8 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)
>  	RTE_ETH_VALID_PORTID_OR_RET(port_id);
>  	dev = &rte_eth_devices[port_id];
>  
> -	if (dev->data->dev_conf.intr_conf.lsc)
> +	if (dev->data->dev_conf.intr_conf.lsc &&
> +	    dev->data->dev_started)
>  		rte_eth_linkstatus_get(dev, eth_link);
>  	else {
>  		RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
> -- 
> 2.12.0
> 

Thanks,

[1] https://dpdk.org/ml/archives/dev/2018-April/094788.html
Thomas Monjalon April 10, 2018, 8:29 a.m. UTC | #2 
10/04/2018 10:20, Nélio Laranjeiro:
> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
> > When application works with LSC interrupts the ethdev layer skips
> > the PMD callback and update according to the link status exists on
> > device data. It is because it assumes the link status on the device data
> > is the correct one since any link change is processed by the application.
> > 
> > As multiple PMDs install the link status interrupt handler only on port
> > start and uninstall it on port stop, the link status may be incorrect in
> > case the query is called after port stop or before port start.
> 
> It seems also logical to not process interrupts from stopped device,
> for them accessing to the link status should always end by calling the
> devop function.
> 
> This patch is the result of discussion on thread [1].
> 
> > Fixing the query implementation to use the PMD callback for such cases.
> > 
> > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
> > Cc: stable@dpdk.org
> > Cc: stephen@networkplumber.org
> > Cc: nelio.laranjeiro@6wind.com
> 
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Looks OK

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Ferruh Yigit April 10, 2018, 6:34 p.m. UTC | #3 
On 4/10/2018 9:29 AM, Thomas Monjalon wrote:
> 10/04/2018 10:20, Nélio Laranjeiro:
>> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
>>> When application works with LSC interrupts the ethdev layer skips
>>> the PMD callback and update according to the link status exists on
>>> device data. It is because it assumes the link status on the device data
>>> is the correct one since any link change is processed by the application.
>>>
>>> As multiple PMDs install the link status interrupt handler only on port
>>> start and uninstall it on port stop, the link status may be incorrect in
>>> case the query is called after port stop or before port start.
>>
>> It seems also logical to not process interrupts from stopped device,
>> for them accessing to the link status should always end by calling the
>> devop function.
>>
>> This patch is the result of discussion on thread [1].
>>
>>> Fixing the query implementation to use the PMD callback for such cases.
>>>
>>> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
>>> Cc: stable@dpdk.org
>>> Cc: stephen@networkplumber.org
>>> Cc: nelio.laranjeiro@6wind.com
>>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Looks OK
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 2c74f7e049..0857670ebe 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1789,7 +1789,8 @@  rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
 	RTE_ETH_VALID_PORTID_OR_RET(port_id);
 	dev = &rte_eth_devices[port_id];
 
-	if (dev->data->dev_conf.intr_conf.lsc)
+	if (dev->data->dev_conf.intr_conf.lsc &&
+	    dev->data->dev_started)
 		rte_eth_linkstatus_get(dev, eth_link);
 	else {
 		RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
@@ -1806,7 +1807,8 @@  rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)
 	RTE_ETH_VALID_PORTID_OR_RET(port_id);
 	dev = &rte_eth_devices[port_id];
 
-	if (dev->data->dev_conf.intr_conf.lsc)
+	if (dev->data->dev_conf.intr_conf.lsc &&
+	    dev->data->dev_started)
 		rte_eth_linkstatus_get(dev, eth_link);
 	else {
 		RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);