diff mbox

[dpdk-dev,v1] mk: fix external build failure

Message ID 20180205102243.16445-1-marko.kovacevic@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kovacevic, Marko Feb. 5, 2018, 10:22 a.m. UTC 
  Updated the make build to fix external build issues

Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
Cc: stable@dpdk.org

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 mk/internal/rte.extvars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Feb. 5, 2018, 10:37 a.m. UTC | #1 
05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues

Please explain what is the issue.

> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org

No need to Cc stable when fixing a bug which is not in a major release.
Kovacevic, Marko Feb. 5, 2018, 10:53 a.m. UTC | #2 
> 05/02/2018 11:22, Marko Kovacevic:
> > Updated the make build to fix external build issues
> 
> Please explain what is the issue.
> 
> > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > Cc: stable@dpdk.org
> 
> No need to Cc stable when fixing a bug which is not in a major release.

Olivier reported an issue this morning, that my commit was breaking 
the build of one of our external module:

make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            

The reason is that entries in $(MAKEFILE_LIST) can be absolute.

Marko.
Thomas Monjalon Feb. 5, 2018, 2:07 p.m. UTC | #3 
05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> > 
> > Please explain what is the issue.
> > 
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> > 
> > No need to Cc stable when fixing a bug which is not in a major release.
> 
> Olivier reported an issue this morning, that my commit was breaking 
> the build of one of our external module:
> 
> make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
> make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            
> 
> The reason is that entries in $(MAKEFILE_LIST) can be absolute.

I know that :)
I was asking to update the commit message in a v2 actually.
Thomas Monjalon Feb. 5, 2018, 6:26 p.m. UTC | #4 
05/02/2018 11:22, Marko Kovacevic:
> Updated the make build to fix external build issues
> 
> Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied, thanks
Thomas Monjalon Feb. 5, 2018, 10:38 p.m. UTC | #5 
05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> > 
> > Please explain what is the issue.
> > 
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> > 
> > No need to Cc stable when fixing a bug which is not in a major release.

Sorry for the confusion.
In this case, Cc stable is needed because it fixes a fix of a bug
seen with previous releases.
diff mbox

Patch

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 19594da..98c8606 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -20,7 +20,7 @@  ifeq ("$(origin M)", "command line")
 RTE_EXTMK := $(abspath $(M))
 endif
 endif
-RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
+RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST)))
 export RTE_EXTMK
 
 # RTE_SDK_BIN must point to .config, include/ and lib/.