diff mbox

[dpdk-dev,v3] doc: add a restriction to multi-process support

Message ID 20171129171713.125795-1-junjie.j.chen@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

junjie.j.chen@intel.com Nov. 29, 2017, 5:17 p.m. UTC
This patch add a restriction to multi-process support: secondary
processes should only run alongside primary process with same DPDK
version, so that secondary processes can use the same hugepage mmap
layout as primary process.

Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
---
v3 changes:
 Use 'note' marker to make it clearer.

 doc/guides/prog_guide/multi_proc_support.rst | 4 ++++
 doc/guides/tools/proc_info.rst               | 4 ++++
 2 files changed, 8 insertions(+)

Comments

Mcnamara, John Dec. 12, 2017, 12:41 p.m. UTC | #1
> -----Original Message-----
> From: Chen, Junjie J
> Sent: Wednesday, November 29, 2017 5:17 PM
> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>; Mcnamara,
> John <john.mcnamara@intel.com>; Tahhan, Maryam <maryam.tahhan@intel.com>;
> dev@dpdk.org
> Cc: Chen, Junjie J <junjie.j.chen@intel.com>
> Subject: [PATCH v3] doc: add a restriction to multi-process support
> 
> This patch add a restriction to multi-process support: secondary processes
> should only run alongside primary process with same DPDK version, so that
> secondary processes can use the same hugepage mmap layout as primary
> process.
> 
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>

Could you mark the previous version of this patch as "Superseded":

http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=&state=&q=restriction+to+multi-process+support&archive=&delegate=


Otherwise:

Acked-by: John McNamara <john.mcnamara@intel.com>
junjie.j.chen@intel.com Dec. 12, 2017, 1:13 p.m. UTC | #2
Done!

Cheers
JJ

> -----Original Message-----
> From: Mcnamara, John
> Sent: Tuesday, December 12, 2017 8:41 PM
> To: Chen, Junjie J <junjie.j.chen@intel.com>; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>; Tahhan, Maryam
> <maryam.tahhan@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v3] doc: add a restriction to multi-process support
> 
> 
> 
> > -----Original Message-----
> > From: Chen, Junjie J
> > Sent: Wednesday, November 29, 2017 5:17 PM
> > To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; Tahhan, Maryam
> > <maryam.tahhan@intel.com>; dev@dpdk.org
> > Cc: Chen, Junjie J <junjie.j.chen@intel.com>
> > Subject: [PATCH v3] doc: add a restriction to multi-process support
> >
> > This patch add a restriction to multi-process support: secondary
> > processes should only run alongside primary process with same DPDK
> > version, so that secondary processes can use the same hugepage mmap
> > layout as primary process.
> >
> > Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> 
> Could you mark the previous version of this patch as "Superseded":
> 
> http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=&state=&q=restri
> ction+to+multi-process+support&archive=&delegate=
> 
> 
> Otherwise:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
Thomas Monjalon Feb. 1, 2018, 2:17 a.m. UTC | #3
> > This patch add a restriction to multi-process support: secondary processes
> > should only run alongside primary process with same DPDK version, so that
> > secondary processes can use the same hugepage mmap layout as primary
> > process.
> > 
> > Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
index 9a9dca7fe..4ca3f2c22 100644
--- a/doc/guides/prog_guide/multi_proc_support.rst
+++ b/doc/guides/prog_guide/multi_proc_support.rst
@@ -52,6 +52,10 @@  Standalone DPDK processes are primary processes,
 while secondary processes can only run alongside a primary process or
 after a primary process has already configured the hugepage shared memory for them.
 
+.. note::
+
+    Secondary processes should run alongside primary process with same DPDK version.
+
 To support these two process types, and other multi-process setups described later,
 two additional command-line parameters are available to the EAL:
 
diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst
index fd17e278c..1b81a7891 100644
--- a/doc/guides/tools/proc_info.rst
+++ b/doc/guides/tools/proc_info.rst
@@ -38,6 +38,10 @@  statistics, resetting port statistics and printing DPDK memory information.
 This application extends the original functionality that was supported by
 dump_cfg.
 
+.. note::
+
+    dpdk-procinfo should run alongside primary process with same DPDK version.
+
 Running the Application
 -----------------------
 The application has a number of command line options: