diff mbox

[dpdk-dev] net/mlx5: fix flow mark action on port start

Message ID 20171115070949.95541-1-shahafs@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shahaf Shuler Nov. 15, 2017, 7:09 a.m. UTC 
  Mark action flag was not set on the flow, causing the rx burst function
after port start to ignore the flow mark.

Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Cc: nelio.laranjeiro@6wind.com

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nélio Laranjeiro Nov. 15, 2017, 7:58 a.m. UTC | #1 
On Wed, Nov 15, 2017 at 09:09:49AM +0200, Shahaf Shuler wrote:
> Mark action flag was not set on the flow, causing the rx burst function
> after port start to ignore the flow mark.
> 
> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 466d74b5f..f32dfdd3f 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1930,6 +1930,7 @@ priv_flow_create(struct priv *priv,
>  	flow->queues = (uint16_t (*)[])(flow + 1);
>  	memcpy(flow->queues, parser.queues, parser.queues_n * sizeof(uint16_t));
>  	flow->queues_n = parser.queues_n;
> +	flow->mark = parser.mark;
>  	/* Copy RSS configuration. */
>  	flow->rss_conf = parser.rss_conf;
>  	flow->rss_conf.rss_key = flow->rss_key;
> -- 
> 2.12.0
 
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Thomas Monjalon Nov. 15, 2017, 8:08 a.m. UTC | #2 
15/11/2017 08:58, Nelio Laranjeiro:
> On Wed, Nov 15, 2017 at 09:09:49AM +0200, Shahaf Shuler wrote:
> > Mark action flag was not set on the flow, causing the rx burst function
> > after port start to ignore the flow mark.
> > 
> > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> > Cc: nelio.laranjeiro@6wind.com
> > 
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>  
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 466d74b5f..f32dfdd3f 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1930,6 +1930,7 @@  priv_flow_create(struct priv *priv,
 	flow->queues = (uint16_t (*)[])(flow + 1);
 	memcpy(flow->queues, parser.queues, parser.queues_n * sizeof(uint16_t));
 	flow->queues_n = parser.queues_n;
+	flow->mark = parser.mark;
 	/* Copy RSS configuration. */
 	flow->rss_conf = parser.rss_conf;
 	flow->rss_conf.rss_key = flow->rss_key;