diff mbox

[dpdk-dev,1/6] testpmd: remove unnecessary void casts

Message ID 20170823154445.19494-2-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Aug. 23, 2017, 3:44 p.m. UTC 
  The testpmd was doing old BSD lint style casts of rte_memcpy
to (void). This is unnecessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test-pmd/cmdline.c | 14 +++++++-------
 app/test-pmd/config.c  |  4 ++--
 app/test-pmd/testpmd.c |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

Comments

Rybalchenko, Kirill Sept. 4, 2017, 11:39 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday 23 August 2017 16:45
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts
> 
> The testpmd was doing old BSD lint style casts of rte_memcpy to (void). This
> is unnecessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test-pmd/cmdline.c | 14 +++++++-------  app/test-pmd/config.c  |  4 ++-
> -  app/test-pmd/testpmd.c |  2 +-
>  3 files changed, 10 insertions(+), 10 deletions(-)
> 

Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Jingjing Wu Sept. 7, 2017, 8:36 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, August 23, 2017 11:45 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts
> 
> The testpmd was doing old BSD lint style casts of rte_memcpy
> to (void). This is unnecessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Ferruh Yigit Sept. 11, 2017, 12:44 p.m. UTC | #3 
On 8/23/2017 4:44 PM, Stephen Hemminger wrote:
> The testpmd was doing old BSD lint style casts of rte_memcpy
> to (void). This is unnecessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

<...>

> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2173,7 +2173,7 @@ init_port_dcb_config(portid_t pid,
>  	 * Set the numbers of RX & TX queues to 0, so
>  	 * the RX & TX queues will not be setup.
>  	 */
> -	(void)rte_eth_dev_configure(pid, 0, 0, &port_conf);
> +	rte_eth_dev_configure(pid, 0, 0, &port_conf);
>  
>  	rte_eth_dev_info_get(pid, &rte_port->dev_info);

According cover letter, intention seems as removing void casts for
rte_memcpy, and all other updates except this one is for rte_memcpy.

Is above change intentional?
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index cd8c358509c2..5c533ffc0d41 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -6960,7 +6960,7 @@  cmd_set_vf_macvlan_parsed(void *parsed_result,
 
 	memset(&filter, 0, sizeof(struct rte_eth_mac_filter));
 
-	(void)rte_memcpy(&filter.mac_addr, &res->address, ETHER_ADDR_LEN);
+	rte_memcpy(&filter.mac_addr, &res->address, ETHER_ADDR_LEN);
 
 	/* set VF MAC filter */
 	filter.is_vf = 1;
@@ -8823,7 +8823,7 @@  cmd_ethertype_filter_parsed(void *parsed_result,
 	memset(&filter, 0, sizeof(filter));
 	if (!strcmp(res->mac, "mac_addr")) {
 		filter.flags |= RTE_ETHTYPE_FLAGS_MAC;
-		(void)rte_memcpy(&filter.mac_addr, &res->mac_addr,
+		rte_memcpy(&filter.mac_addr, &res->mac_addr,
 			sizeof(struct ether_addr));
 	}
 	if (!strcmp(res->drop, "drop"))
@@ -9012,7 +9012,7 @@  do { \
 #define IPV6_ADDR_TO_ARRAY(ip_addr, ip) \
 do { \
 	if ((ip_addr).family == AF_INET6) \
-		(void)rte_memcpy(&(ip), \
+		rte_memcpy(&(ip), \
 				 &((ip_addr).addr.ipv6), \
 				 sizeof(struct in6_addr)); \
 	else { \
@@ -9144,12 +9144,12 @@  cmd_flow_director_filter_parsed(void *parsed_result,
 	}
 
 	if (fdir_conf.mode ==  RTE_FDIR_MODE_PERFECT_MAC_VLAN)
-		(void)rte_memcpy(&entry.input.flow.mac_vlan_flow.mac_addr,
+		rte_memcpy(&entry.input.flow.mac_vlan_flow.mac_addr,
 				 &res->mac_addr,
 				 sizeof(struct ether_addr));
 
 	if (fdir_conf.mode ==  RTE_FDIR_MODE_PERFECT_TUNNEL) {
-		(void)rte_memcpy(&entry.input.flow.tunnel_flow.mac_addr,
+		rte_memcpy(&entry.input.flow.tunnel_flow.mac_addr,
 				 &res->mac_addr,
 				 sizeof(struct ether_addr));
 		entry.input.flow.tunnel_flow.tunnel_type =
@@ -9158,7 +9158,7 @@  cmd_flow_director_filter_parsed(void *parsed_result,
 			rte_cpu_to_be_32(res->tunnel_id_value);
 	}
 
-	(void)rte_memcpy(entry.input.flow_ext.flexbytes,
+	rte_memcpy(entry.input.flow_ext.flexbytes,
 		   flexbytes,
 		   RTE_ETH_FDIR_MAX_FLEXLEN);
 
@@ -9856,7 +9856,7 @@  cmd_flow_director_flex_mask_parsed(void *parsed_result,
 			memset(&port->dev_conf.fdir_conf.flex_conf.flex_mask[i],
 			       0, sizeof(struct rte_eth_fdir_flex_mask));
 		port->dev_conf.fdir_conf.flex_conf.nb_flexmasks = 1;
-		(void)rte_memcpy(&port->dev_conf.fdir_conf.flex_conf.flex_mask[0],
+		rte_memcpy(&port->dev_conf.fdir_conf.flex_conf.flex_mask[0],
 				 &flex_mask,
 				 sizeof(struct rte_eth_fdir_flex_mask));
 		cmd_reconfig_device_queue(res->port_id, 1, 1);
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 3ae3e1cd8bc9..ca83eef99cb1 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3004,7 +3004,7 @@  fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg)
 			return;
 		}
 	}
-	(void)rte_memcpy(&flex_conf->flex_mask[idx],
+	rte_memcpy(&flex_conf->flex_mask[idx],
 			 cfg,
 			 sizeof(struct rte_eth_fdir_flex_mask));
 }
@@ -3034,7 +3034,7 @@  fdir_set_flex_payload(portid_t port_id, struct rte_eth_flex_payload_cfg *cfg)
 			return;
 		}
 	}
-	(void)rte_memcpy(&flex_conf->flex_set[idx],
+	rte_memcpy(&flex_conf->flex_set[idx],
 			 cfg,
 			 sizeof(struct rte_eth_flex_payload_cfg));
 
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 7d40139416c5..0af34473af3a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2173,7 +2173,7 @@  init_port_dcb_config(portid_t pid,
 	 * Set the numbers of RX & TX queues to 0, so
 	 * the RX & TX queues will not be setup.
 	 */
-	(void)rte_eth_dev_configure(pid, 0, 0, &port_conf);
+	rte_eth_dev_configure(pid, 0, 0, &port_conf);
 
 	rte_eth_dev_info_get(pid, &rte_port->dev_info);