diff mbox series

eal: remove return from functions declared void return type

Message ID 1697547819-5448-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series eal: remove return from functions declared void return type |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Tyler Retzlaff Oct. 17, 2023, 1:03 p.m. UTC 
  Remove return from rte_free and eal_free_no_trace both functions are
declared to have a return type of void so they shouldn't return a value.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/common/rte_malloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Morten Brørup Oct. 17, 2023, 1:14 p.m. UTC | #1 
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Tuesday, 17 October 2023 15.04
> 
> Remove return from rte_free and eal_free_no_trace both functions are
> declared to have a return type of void so they shouldn't return a value.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Patrick Robb Oct. 17, 2023, 5:51 p.m. UTC | #2 
Recheck-request: iol-broadcom-Functional

Sorry, this series was affected by an infra failure today.
Tyler Retzlaff Oct. 17, 2023, 7:29 p.m. UTC | #3 
On Tue, Oct 17, 2023 at 01:51:39PM -0400, Patrick Robb wrote:
> Recheck-request: iol-broadcom-Functional
> 
> Sorry, this series was affected by an infra failure today.

No big deal, I haven't got a lot of concerns over the correctness of
this particular series. :)
David Marchand Oct. 26, 2023, 8:42 a.m. UTC | #4 
On Tue, Oct 17, 2023 at 3:15 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Tuesday, 17 October 2023 15.04
> >
> > Remove return from rte_free and eal_free_no_trace both functions are
> > declared to have a return type of void so they shouldn't return a value.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c
index ebafef3..9db0c39 100644
--- a/lib/eal/common/rte_malloc.c
+++ b/lib/eal/common/rte_malloc.c
@@ -41,13 +41,13 @@ 
 void
 rte_free(void *addr)
 {
-	return mem_free(addr, true);
+	mem_free(addr, true);
 }
 
 void
 eal_free_no_trace(void *addr)
 {
-	return mem_free(addr, false);
+	mem_free(addr, false);
 }
 
 static void *