diff mbox series

[v4,3/4] build: limit what is built when using MSVC compiler

Message ID 1691778287-15746-4-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series enable use of the MSVC compiler |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Tyler Retzlaff Aug. 11, 2023, 6:24 p.m. UTC 
  Build only kvargs and telemetry when is_ms_compiler.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/meson.build       | 6 ++++--
 drivers/meson.build   | 4 ++++
 lib/meson.build       | 8 ++++++++
 usertools/meson.build | 4 ++++
 4 files changed, 20 insertions(+), 2 deletions(-)

Comments

Tyler Retzlaff Aug. 11, 2023, 6:26 p.m. UTC | #1 
On Fri, Aug 11, 2023 at 11:24:46AM -0700, Tyler Retzlaff wrote:
> Build only kvargs and telemetry when is_ms_compiler.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/meson.build       | 6 ++++--
>  drivers/meson.build   | 4 ++++
>  lib/meson.build       | 8 ++++++++
>  usertools/meson.build | 4 ++++
>  4 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index 4fc1a83..23a9d2e 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -1,6 +1,10 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017-2019 Intel Corporation
>  
> +if is_ms_compiler
> +    subdir_done()
> +endif
> +
>  disable_apps = ',' + get_option('disable_apps')
>  disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split()
>  
> @@ -38,8 +42,6 @@ if get_option('default_library') == 'static' and not is_windows
>      default_ldflags += ['-Wl,--export-dynamic']
>  endif
>  
> -enabled_apps = [] # used to print summary at the end
> -

oops, i shouldn't have removed this since David's patch removes it
already. please ignore this removal when reviewing.
diff mbox series

Patch

diff --git a/app/meson.build b/app/meson.build
index 4fc1a83..23a9d2e 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,6 +1,10 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
+if is_ms_compiler
+    subdir_done()
+endif
+
 disable_apps = ',' + get_option('disable_apps')
 disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split()
 
@@ -38,8 +42,6 @@  if get_option('default_library') == 'static' and not is_windows
     default_ldflags += ['-Wl,--export-dynamic']
 endif
 
-enabled_apps = [] # used to print summary at the end
-
 foreach app:apps
     name = app
     build = true
diff --git a/drivers/meson.build b/drivers/meson.build
index c909070..417b64b 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,10 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
+if is_ms_compiler
+    subdir_done()
+endif
+
 fs = import('fs')
 
 # Defines the order of dependencies evaluation
diff --git a/lib/meson.build b/lib/meson.build
index 7da3698..77c3e74 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -66,6 +66,14 @@  libraries = [
         'node',
 ]
 
+if is_ms_compiler
+    libraries = [
+            'log',
+            'kvargs',
+            'telemetry',
+    ]
+endif
+
 optional_libs = [
         'bitratestats',
         'cfgfile',
diff --git a/usertools/meson.build b/usertools/meson.build
index 0efa4a8..740b483 100644
--- a/usertools/meson.build
+++ b/usertools/meson.build
@@ -1,6 +1,10 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
+if is_ms_compiler
+    subdir_done()
+endif
+
 install_data([
             'dpdk-devbind.py',
             'dpdk-pmdinfo.py',