[2/2] net/ice: fix dropped packets statistics name

Message ID 1559550688-9290-2-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [1/2] net/i40e: fix dropped packets statistics name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

David Marchand June 3, 2019, 8:31 a.m. UTC
  Copy/paste from i40e, let's align with the fix on i40e.

Fixes: a37bde56314d ("net/ice: support statistics")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Eelco Chaudron June 3, 2019, 8:52 a.m. UTC | #1
Looks good to me…

Acked-by: Eelco Chaudron <echaudro@redhat.com>

On 3 Jun 2019, at 10:31, David Marchand wrote:

> Copy/paste from i40e, let's align with the fix on i40e.
>
> Fixes: a37bde56314d ("net/ice: support statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index bdbceb4..6cd1c74 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -153,13 +153,13 @@ struct ice_xstats_name_off {
>  	{"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
>  	{"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
>  	{"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
> -	{"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
> +	{"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
>  	{"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
>  		rx_unknown_protocol)},
>  	{"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
>  	{"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
>  	{"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
> -	{"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
> +	{"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
>  };
>
>  #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \
> -- 
> 1.8.3.1
  
Qi Zhang June 18, 2019, 2:02 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Eelco Chaudron
> Sent: Monday, June 3, 2019 4:53 PM
> To: David Marchand <david.marchand@redhat.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>;
> Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/ice: fix dropped packets
> statistics name
> 
> Looks good to me…
> 
> Acked-by: Eelco Chaudron <echaudro@redhat.com>
> 
> On 3 Jun 2019, at 10:31, David Marchand wrote:
> 
> > Copy/paste from i40e, let's align with the fix on i40e.
> >
> > Fixes: a37bde56314d ("net/ice: support statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  drivers/net/ice/ice_ethdev.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c
> > b/drivers/net/ice/ice_ethdev.c index bdbceb4..6cd1c74 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -153,13 +153,13 @@ struct ice_xstats_name_off {
> >  	{"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
> >  	{"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
> >  	{"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
> > -	{"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
> > +	{"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
> >  	{"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
> >  		rx_unknown_protocol)},
> >  	{"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
> >  	{"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
> >  	{"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
> > -	{"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
> > +	{"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
> >  };
> >
> >  #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \
> > --
> > 1.8.3.1

Applied to dpdk-next-next-intel.

Thanks
Qi
  

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index bdbceb4..6cd1c74 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -153,13 +153,13 @@  struct ice_xstats_name_off {
 	{"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
 	{"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
 	{"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
-	{"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
+	{"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
 	{"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
 		rx_unknown_protocol)},
 	{"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
 	{"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
 	{"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
-	{"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
+	{"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
 };
 
 #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \