[v2,2/2] net/bnx2x: bump version to 1.0.7.1

Message ID 1542447449-19888-2-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series None |

Checks

Context Check Description
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh Nov. 17, 2018, 9:37 a.m. UTC
  Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/bnx2x/bnx2x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Nov. 19, 2018, 1:27 p.m. UTC | #1
On 11/17/2018 9:37 AM, Mody, Rasesh wrote:
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

Hi Rasesh,

18.11-rc4 is out and this patchset was late for it, I suggest postponing
previous patch, `cleanup info logs`, in to next release (v19.02)

But not sure about this patch, I guess this is to mark the changes in this
release, it looks like there is no API using this information so applications
don't require version information but it is just for logging.
Can you please advise on to get or postpone this version update patch (without
getting other patch in the series) ?

> ---
>  drivers/net/bnx2x/bnx2x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
> index c80f84c..4c775c1 100644
> --- a/drivers/net/bnx2x/bnx2x.c
> +++ b/drivers/net/bnx2x/bnx2x.c
> @@ -29,7 +29,7 @@
>  #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
>  #define BNX2X_PMD_VERSION_MAJOR 1
>  #define BNX2X_PMD_VERSION_MINOR 0
> -#define BNX2X_PMD_VERSION_REVISION 6
> +#define BNX2X_PMD_VERSION_REVISION 7
>  #define BNX2X_PMD_VERSION_PATCH 1
>  
>  static inline const char *
>
  
Mody, Rasesh Nov. 19, 2018, 6:48 p.m. UTC | #2
Hi Ferruh,

>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Monday, November 19, 2018 5:28 AM
>
>On 11/17/2018 9:37 AM, Mody, Rasesh wrote:
>> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>
>Hi Rasesh,
>
>18.11-rc4 is out and this patchset was late for it, I suggest postponing previous
>patch, `cleanup info logs`, in to next release (v19.02)

As `cleanup info logs` is non-critical patch it is ok to push it out to v19.02 and then pull it in v18.11 stable.

>
>But not sure about this patch, I guess this is to mark the changes in this
>release, it looks like there is no API using this information so applications don't
>require version information but it is just for logging.
>Can you please advise on to get or postpone this version update patch
>(without getting other patch in the series) ?

Yes, the version information is for logging and mark changes in current release. Can you please apply this patch to v18.11 release?

Thanks!
-Rasesh
>
>> ---
>>  drivers/net/bnx2x/bnx2x.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
>> index c80f84c..4c775c1 100644
>> --- a/drivers/net/bnx2x/bnx2x.c
>> +++ b/drivers/net/bnx2x/bnx2x.c
>> @@ -29,7 +29,7 @@
>>  #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
>>  #define BNX2X_PMD_VERSION_MAJOR 1
>>  #define BNX2X_PMD_VERSION_MINOR 0
>> -#define BNX2X_PMD_VERSION_REVISION 6
>> +#define BNX2X_PMD_VERSION_REVISION 7
>>  #define BNX2X_PMD_VERSION_PATCH 1
>>
>>  static inline const char *
>>
  
Ferruh Yigit Nov. 20, 2018, 9:22 a.m. UTC | #3
On 11/17/2018 9:37 AM, Mody, Rasesh wrote:
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

Applied to dpdk-next-net/master, thanks.

(patch 1/2 deferred to next release.)
  

Patch

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index c80f84c..4c775c1 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -29,7 +29,7 @@ 
 #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
 #define BNX2X_PMD_VERSION_MAJOR 1
 #define BNX2X_PMD_VERSION_MINOR 0
-#define BNX2X_PMD_VERSION_REVISION 6
+#define BNX2X_PMD_VERSION_REVISION 7
 #define BNX2X_PMD_VERSION_PATCH 1
 
 static inline const char *