[2/2] test/eventdev: remove eth Rx adapter vdev workaround
Checks
Commit Message
eth Rx adapter has been updated to support hotplugged
devices, devices created after adapter creation can now be
added to the adapter.
Update the adapter_multi_eth_add_del
test case to create the adapter as part of test setup
instead of creating it after creating vdevs.
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
test/test/test_event_eth_rx_adapter.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
Comments
-----Original Message-----
> Date: Thu, 6 Sep 2018 14:41:43 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround
> X-Mailer: git-send-email 1.8.3.1
>
>
> eth Rx adapter has been updated to support hotplugged
> devices, devices created after adapter creation can now be
> added to the adapter.
>
> Update the adapter_multi_eth_add_del
> test case to create the adapter as part of test setup
> instead of creating it after creating vdevs.
>
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> test/test/test_event_eth_rx_adapter.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 4cca77f..d6d137e 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -489,9 +489,6 @@ struct event_eth_rx_adapter_test_params {
> err = init_ports(rte_eth_dev_count_total());
> TEST_ASSERT(err == 0, "Port initialization failed err %d\n", err);
>
> - /* creating new instance for all newly added eth devices */
> - adapter_create();
> -
> /* eth_rx_adapter_queue_add for n ports */
> port_index = 0;
> for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
> @@ -509,8 +506,6 @@ struct event_eth_rx_adapter_test_params {
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> }
>
> - adapter_free();
> -
> return TEST_SUCCESS;
> }
>
> @@ -675,7 +670,8 @@ struct event_eth_rx_adapter_test_params {
> TEST_CASE_ST(NULL, NULL, adapter_create_free),
> TEST_CASE_ST(adapter_create, adapter_free,
> adapter_queue_add_del),
> - TEST_CASE_ST(NULL, NULL, adapter_multi_eth_add_del),
> + TEST_CASE_ST(adapter_create, adapter_free,
> + adapter_multi_eth_add_del),
> TEST_CASE_ST(adapter_create, adapter_free, adapter_start_stop),
> TEST_CASE_ST(adapter_create, adapter_free, adapter_stats),
> TEST_CASES_END() /**< NULL terminate unit test array */
> --
> 1.8.3.1
>
@@ -489,9 +489,6 @@ struct event_eth_rx_adapter_test_params {
err = init_ports(rte_eth_dev_count_total());
TEST_ASSERT(err == 0, "Port initialization failed err %d\n", err);
- /* creating new instance for all newly added eth devices */
- adapter_create();
-
/* eth_rx_adapter_queue_add for n ports */
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
@@ -509,8 +506,6 @@ struct event_eth_rx_adapter_test_params {
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
- adapter_free();
-
return TEST_SUCCESS;
}
@@ -675,7 +670,8 @@ struct event_eth_rx_adapter_test_params {
TEST_CASE_ST(NULL, NULL, adapter_create_free),
TEST_CASE_ST(adapter_create, adapter_free,
adapter_queue_add_del),
- TEST_CASE_ST(NULL, NULL, adapter_multi_eth_add_del),
+ TEST_CASE_ST(adapter_create, adapter_free,
+ adapter_multi_eth_add_del),
TEST_CASE_ST(adapter_create, adapter_free, adapter_start_stop),
TEST_CASE_ST(adapter_create, adapter_free, adapter_stats),
TEST_CASES_END() /**< NULL terminate unit test array */