test/event: remove RSS config in eth Rx adapter test

Message ID 1536140526-7668-1-git-send-email-nikhil.rao@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series test/event: remove RSS config in eth Rx adapter test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rao, Nikhil Sept. 5, 2018, 9:42 a.m. UTC
  Remove RSS config as it is not required (this also fixes an
error with a hardcoded RSS config not supported by the NIC)

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
CC: stable@dpdk.org
---
 test/test/test_event_eth_rx_adapter.c | 7 -------
 1 file changed, 7 deletions(-)
  

Comments

Jerin Jacob Sept. 20, 2018, 4:59 a.m. UTC | #1
-----Original Message-----
> Date: Wed, 5 Sep 2018 15:12:06 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] test/event: remove RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
> 
> External Email
> 
> Remove RSS config as it is not required (this also fixes an
> error with a hardcoded RSS config not supported by the NIC)
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
> ---
>  test/test/test_event_eth_rx_adapter.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..4cca77f 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -117,13 +117,6 @@ struct event_eth_rx_adapter_test_params {
>                         .mq_mode = ETH_MQ_RX_RSS,

Ideally you need to set .mq_mode as ETH_MQ_RX_NONE to disable RSS.

>                         .max_rx_pkt_len = ETHER_MAX_LEN
>                 },
> -               .rx_adv_conf = {
> -                       .rss_conf = {
> -                               .rss_hf = ETH_RSS_IP |
> -                                       ETH_RSS_TCP |
> -                                       ETH_RSS_UDP,
> -                       }
> -               }
>         };
> 
>         return port_init_common(port, &port_conf_default, mp);
> --
> 1.8.3.1
>
  

Patch

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 2337e54..4cca77f 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -117,13 +117,6 @@  struct event_eth_rx_adapter_test_params {
 			.mq_mode = ETH_MQ_RX_RSS,
 			.max_rx_pkt_len = ETHER_MAX_LEN
 		},
-		.rx_adv_conf = {
-			.rss_conf = {
-				.rss_hf = ETH_RSS_IP |
-					ETH_RSS_TCP |
-					ETH_RSS_UDP,
-			}
-		}
 	};
 
 	return port_init_common(port, &port_conf_default, mp);