diff mbox

[dpdk-dev] net/nfp: remove reference to old offload API

Message ID 1527070484-35412-1-git-send-email-alejandro.lucero@netronome.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Alejandro Lucero May 23, 2018, 10:14 a.m. UTC 
  This was missed in a previous patch for using new offload API.

It turns out the line can be removed because that internal PMD
crc_len data is not being used.

Fixes: a922c6a789ff ("net/nfp: support new HW offloads API")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfp_net.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ferruh Yigit May 23, 2018, 3:52 p.m. UTC | #1 
On 5/23/2018 11:14 AM, Alejandro Lucero wrote:
> This was missed in a previous patch for using new offload API.
> 
> It turns out the line can be removed because that internal PMD
> crc_len data is not being used.
> 
> Fixes: a922c6a789ff ("net/nfp: support new HW offloads API")
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Hi Alejandro,

Normally we are not getting non-critical fixes after this point, but to complete
offload API work and since this was requested fix, patch will be considered for
release, thanks.
Ferruh Yigit May 24, 2018, 1:22 p.m. UTC | #2 
On 5/23/2018 4:52 PM, Ferruh Yigit wrote:
> On 5/23/2018 11:14 AM, Alejandro Lucero wrote:
>> This was missed in a previous patch for using new offload API.
>>
>> It turns out the line can be removed because that internal PMD
>> crc_len data is not being used.
>>
>> Fixes: a922c6a789ff ("net/nfp: support new HW offloads API")
>>
>> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> 
> Hi Alejandro,
> 
> Normally we are not getting non-critical fixes after this point, but to complete
> offload API work and since this was requested fix, patch will be considered for
> release, thanks.

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 80dc273..34a8cad 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -1508,8 +1508,6 @@  enum nfp_qcp_ptr {
 	rxq->rx_count = nb_desc;
 	rxq->port_id = dev->data->port_id;
 	rxq->rx_free_thresh = rx_conf->rx_free_thresh;
-	rxq->crc_len = (uint8_t) ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0
-				  : ETHER_CRC_LEN);
 	rxq->drop_en = rx_conf->rx_drop_en;
 
 	/*