diff mbox

[dpdk-dev,01/11] cryptodev: add compile support for AMD CCP crypto PMD

Message ID 1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com (mailing list archive)
State Changes Requested, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Kumar, Ravi1 Nov. 30, 2017, 1:12 p.m. UTC 
  Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
 MAINTAINERS             | 6 ++++++
 config/common_base      | 5 +++++
 drivers/crypto/Makefile | 1 +
 mk/rte.app.mk           | 2 ++
 4 files changed, 14 insertions(+)

Comments

De Lara Guarch, Pablo Dec. 11, 2017, 1:39 p.m. UTC | #1 
Hi Ravi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar
> Sent: Thursday, November 30, 2017 1:12 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for
> AMD CCP crypto PMD
> 

Thanks for splitting the original patch into multiple ones.
However, in this case, this should get merged to the other patches,
as all the changes are referencing files/folders that do not exist yet.

Apart from this, two comments below.

Thanks,
Pablo

> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  MAINTAINERS             | 6 ++++++
>  config/common_base      | 5 +++++
>  drivers/crypto/Makefile | 1 +
>  mk/rte.app.mk           | 2 ++
>  4 files changed, 14 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f0baeb4..daac82e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -588,6 +588,12 @@ M: Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
>  T: git://dpdk.org/next/dpdk-next-crypto
>  F: doc/guides/cryptodevs/features/default.ini
> 
> +AMD CCP Crypto PMD

Remove trailing whitespace here.

> +M: Ravi Kumar <ravi1.kumar@amd.com>
> +F: drivers/crypto/ccp/
> +F: doc/guides/cryptodevs/ccp.rst
> +F: doc/guides/cryptodevs/features/ccp.ini

Add these lines, as you add the files.

> +
Kumar, Ravi1 Dec. 11, 2017, 1:41 p.m. UTC | #2 
>Hi Ravi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar
>> Sent: Thursday, November 30, 2017 1:12 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for 
>> AMD CCP crypto PMD
>> 
>
>Thanks for splitting the original patch into multiple ones.
>However, in this case, this should get merged to the other patches, as all the changes are referencing files/folders that do not exist yet.
>
>Apart from this, two comments below.
>
>Thanks,
>Pablo
>
>> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> ---
>>  MAINTAINERS             | 6 ++++++
>>  config/common_base      | 5 +++++
>>  drivers/crypto/Makefile | 1 +
>>  mk/rte.app.mk           | 2 ++
>>  4 files changed, 14 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..daac82e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -588,6 +588,12 @@ M: Pablo de Lara
>> <pablo.de.lara.guarch@intel.com>
>>  T: git://dpdk.org/next/dpdk-next-crypto
>>  F: doc/guides/cryptodevs/features/default.ini
>> 
>> +AMD CCP Crypto PMD
>
>Remove trailing whitespace here.
>
>> +M: Ravi Kumar <ravi1.kumar@amd.com>
>> +F: drivers/crypto/ccp/
>> +F: doc/guides/cryptodevs/ccp.rst
>> +F: doc/guides/cryptodevs/features/ccp.ini
>
>Add these lines, as you add the files.
>
>> +
>
>
Hi Pablo,

Thanks for the review comments. Will work on it.

Regards,
Ravi
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f0baeb4..daac82e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -588,6 +588,12 @@  M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: doc/guides/cryptodevs/features/default.ini
 
+AMD CCP Crypto PMD 
+M: Ravi Kumar <ravi1.kumar@amd.com>
+F: drivers/crypto/ccp/
+F: doc/guides/cryptodevs/ccp.rst
+F: doc/guides/cryptodevs/features/ccp.ini
+
 ARMv8 Crypto
 M: Jerin Jacob <jerin.jacob@caviumnetworks.com>
 F: drivers/crypto/armv8/
diff --git a/config/common_base b/config/common_base
index e74febe..88826c8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -557,6 +557,11 @@  CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n
 CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
 
 #
+# Compile PMD for AMD CCP crypto device
+#
+CONFIG_RTE_LIBRTE_PMD_CCP=n
+
+#
 # Compile PMD for Marvell Crypto device
 #
 CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO=n
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index 645b696..b378643 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -44,5 +44,6 @@  DIRS-$(CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO) += mrvl
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += null
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += dpaa2_sec
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += dpaa_sec
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_CCP) += ccp
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 6a6a745..0453b7f 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -191,6 +191,8 @@  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC)   += -lrte_bus_dpaa
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC)   += -lrte_pmd_dpaa_sec
 endif # CONFIG_RTE_LIBRTE_DPAA_BUS
 
+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CCP)   += -lrte_pmd_ccp -lcrypto
+
 endif # CONFIG_RTE_LIBRTE_CRYPTODEV
 
 ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)