[dpdk-dev,4/4] doc: add switch restart support to fm10k guide
Checks
Commit Message
This patch documents how DPDK app should handle the event of switch
quit-restart to resume its network without an app-level restart.
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
doc/guides/nics/fm10k.rst | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> Sent: Sunday, October 22, 2017 10:37 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH 4/4] doc: add switch restart support to fm10k
> guide
>
> This patch documents how DPDK app should handle the event of switch quit-
> restart to resume its network without an app-level restart.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
I'd suggest some minor changes as follows:
Support for Switch Restart
~~~~~~~~~~~~~~~~~~~~~~~~~~
For FM10000 multi host based design a DPDK app running in the VM or host needs
to be aware of the switch's state since it may undergo a quit-restart. When
the switch goes down the DPDK app will receive a LSC event indicating link
status down, and the app should stop the worker threads that are polling on
the Rx/Tx queues. When switch comes up, a LSC event indicating ``LINK_UP`` is
sent to the app, which can then restart the FM100 port to resume network
processing.
> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, October 23, 2017 9:07 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 4/4] doc: add switch restart support to fm10k
> guide
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiao Wang
> > Sent: Sunday, October 22, 2017 10:37 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> > Subject: [dpdk-dev] [PATCH 4/4] doc: add switch restart support to fm10k
> > guide
> >
> > This patch documents how DPDK app should handle the event of switch quit-
> > restart to resume its network without an app-level restart.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>
>
> I'd suggest some minor changes as follows:
>
>
> Support for Switch Restart
> ~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> For FM10000 multi host based design a DPDK app running in the VM or host
> needs
> to be aware of the switch's state since it may undergo a quit-restart. When
> the switch goes down the DPDK app will receive a LSC event indicating link
> status down, and the app should stop the worker threads that are polling on
> the Rx/Tx queues. When switch comes up, a LSC event indicating ``LINK_UP`` is
> sent to the app, which can then restart the FM100 port to resume network
> processing.
Thanks John, I will make it in v2.
BRs,
Xiao
For fm10k multi host based design, DPDK app running in VM or host needs to
get aware of the switch's state because switch may undergo a quit-restart.
This patch series supports switch restart feature for DPDK app to be able
to resume its packet processing without an app-level restart.
Changes in v2:
- Improve function description wording in fm10k guide.
- Fix checkpatch warnings.
Xiao Wang (4):
net/fm10k: redefine link status semantics
net/fm10k: support switch restart on PF
net/fm10k: support switch restart on VF
doc: add switch restart support to fm10k guide
doc/guides/nics/fm10k.rst | 11 ++++
drivers/net/fm10k/fm10k.h | 1 +
drivers/net/fm10k/fm10k_ethdev.c | 106 ++++++++++++++++++++++++++++++++++++---
3 files changed, 112 insertions(+), 6 deletions(-)
On 10/24/2017 6:45 AM, Xiao Wang wrote:
> For fm10k multi host based design, DPDK app running in VM or host needs to
> get aware of the switch's state because switch may undergo a quit-restart.
> This patch series supports switch restart feature for DPDK app to be able
> to resume its packet processing without an app-level restart.
>
> Changes in v2:
> - Improve function description wording in fm10k guide.
> - Fix checkpatch warnings.
>
> Xiao Wang (4):
> net/fm10k: redefine link status semantics
> net/fm10k: support switch restart on PF
> net/fm10k: support switch restart on VF
> doc: add switch restart support to fm10k guide
Series Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 10/24/2017 12:29 PM, Ferruh Yigit wrote:
> On 10/24/2017 6:45 AM, Xiao Wang wrote:
>> For fm10k multi host based design, DPDK app running in VM or host needs to
>> get aware of the switch's state because switch may undergo a quit-restart.
>> This patch series supports switch restart feature for DPDK app to be able
>> to resume its packet processing without an app-level restart.
>>
>> Changes in v2:
>> - Improve function description wording in fm10k guide.
>> - Fix checkpatch warnings.
>>
>> Xiao Wang (4):
>> net/fm10k: redefine link status semantics
>> net/fm10k: support switch restart on PF
>> net/fm10k: support switch restart on VF
>> doc: add switch restart support to fm10k guide
>
> Series Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.
@@ -161,6 +161,16 @@ FM10000 PMD driver. The switch driver can be acquired from Intel support.
Only Testpoint is validated with DPDK, the latest version that has been
validated with DPDK is 4.1.6.
+Support Switch Restart
+~~~~~~~~~~~~~~~~~~~~~~
+
+For fm10k multi host based design, DPDK app running in VM or host needs to
+get aware of the switch's state because switch may undergo a quit-restart.
+When switch goes down, DPDK app receives a LSC event indicating link status
+turns down, and app should stop the worker threads that are polling on the
+Rx/Tx queues. When switch gets up, a LSC event indicating LINK_UP is sent to
+the app, then app can restart fm10k port to resume its network processing.
+
CRC striping
~~~~~~~~~~~~