diff mbox

[dpdk-dev] net/e1000: add support 2-tuple filter on i210/i211

Message ID 1496641257-29375-1-git-send-email-wei.zhao1@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Zhao1, Wei June 5, 2017, 5:40 a.m. UTC 
  Add support of i210 and i211 type nic in 2-tuple filter.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Wenzhuo Lu June 5, 2017, 6:14 a.m. UTC | #1 
Hi,


> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, June 5, 2017 1:41 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Zhao1, Wei
> Subject: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> 
> Add support of i210 and i211 type nic in 2-tuple filter.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Zhao1, Wei June 5, 2017, 6:16 a.m. UTC | #2 
Hi ,wenzhuo

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Monday, June 5, 2017 2:15 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> 
> Hi,
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, June 5, 2017 1:41 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; Zhao1, Wei
> > Subject: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> >
> > Add support of i210 and i211 type nic in 2-tuple filter.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

I will commit v3 later  to rework code as your suggestion.
Zhao1, Wei June 6, 2017, 7:22 a.m. UTC | #3 
I'm sorry for this mistake, this patch is ok and I will not deliver a new version.
The mail about v3 before is intended to be reply to another mail else.

Thank you.

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, June 5, 2017 2:16 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> 
> Hi ,wenzhuo
> 
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Monday, June 5, 2017 2:15 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> > Subject: RE: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> >
> > Hi,
> >
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Monday, June 5, 2017 1:41 PM
> > > To: dev@dpdk.org
> > > Cc: Lu, Wenzhuo; Zhao1, Wei
> > > Subject: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
> > >
> > > Add support of i210 and i211 type nic in 2-tuple filter.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> I will commit v3 later  to rework code as your suggestion.
Ferruh Yigit June 6, 2017, 10:42 a.m. UTC | #4 
On 6/5/2017 7:14 AM, Lu, Wenzhuo wrote:
> Hi,
> 
> 
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Monday, June 5, 2017 1:41 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo; Zhao1, Wei
>> Subject: [PATCH] net/e1000: add support 2-tuple filter on i210/i211
>>
>> Add support of i210 and i211 type nic in 2-tuple filter.
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 2817fbb..37cefc3 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4543,7 +4543,9 @@  igb_add_del_ntuple_filter(struct rte_eth_dev *dev,
 		break;
 	case RTE_2TUPLE_FLAGS:
 	case (RTE_2TUPLE_FLAGS | RTE_NTUPLE_FLAGS_TCP_FLAG):
-		if (hw->mac.type != e1000_82580 && hw->mac.type != e1000_i350)
+		if (hw->mac.type != e1000_82580 && hw->mac.type != e1000_i350 &&
+			hw->mac.type != e1000_i210 &&
+			hw->mac.type != e1000_i211)
 			return -ENOTSUP;
 		if (add)
 			ret = igb_add_2tuple_filter(dev, ntuple_filter);