diff mbox

[dpdk-dev] eal: add Bus log type

Message ID 1495604325-15743-1-git-send-email-shreyansh.jain@nxp.com (mailing list archive)
State Rejected, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shreyansh Jain May 24, 2017, 5:38 a.m. UTC 
  Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 This was missed while adding the rte_bus code. (But, this is not a fix)
 Also, I couldn't find any maintainer listed for common/include/* code
 in MAINTAINERS, so, sending 'to' dev@ list.


 lib/librte_eal/common/include/rte_log.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Shreyansh Jain June 19, 2017, 11:03 a.m. UTC | #1 
Hello Thomas,

On Wednesday 24 May 2017 11:08 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>   This was missed while adding the rte_bus code. (But, this is not a fix)
>   Also, I couldn't find any maintainer listed for common/include/* code
>   in MAINTAINERS, so, sending 'to' dev@ list.
> 
> 
>   lib/librte_eal/common/include/rte_log.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
> index 3419138..1e45e87 100644
> --- a/lib/librte_eal/common/include/rte_log.h
> +++ b/lib/librte_eal/common/include/rte_log.h
> @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
>   #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
>   #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
>   #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
> +#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
>   
>   /* these log types can be used in an application */
>   #define RTE_LOGTYPE_USER1     24 /**< User-defined log type 1. */
> 

Just wanted to ping - is there something wrong/unacceptable about this?

-
Shreyansh
Thomas Monjalon June 19, 2017, 8:54 p.m. UTC | #2 
19/06/2017 13:03, Shreyansh Jain:
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
> >   #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
> >   #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
> >   #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
> > +#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
> 
> Just wanted to ping - is there something wrong/unacceptable about this?

Sorry for not replying before.

The strange thing is that it is not used.
At least, the existing bus logs should be converted.
I've spotted few lines in drivers/bus/fslmc/.

And more importantly, we must switch to the new dynamic types
using rte_log_register().
Shreyansh Jain July 2, 2017, 5:31 a.m. UTC | #3 
On Tuesday 20 June 2017 02:24 AM, Thomas Monjalon wrote:
> 19/06/2017 13:03, Shreyansh Jain:
>>> --- a/lib/librte_eal/common/include/rte_log.h
>>> +++ b/lib/librte_eal/common/include/rte_log.h
>>> @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
>>>   #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
>>>   #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
>>>   #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
>>> +#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
>>
>> Just wanted to ping - is there something wrong/unacceptable about this?
> 
> Sorry for not replying before.

And I am sorry for spotting your reply so late.

> 
> The strange thing is that it is not used.

Yes, because somehow I forgot this while pushing bus/fslmc. I (had (*)) plan to change this for bus/fslmc in subsequent patches.

> At least, the existing bus logs should be converted.
> I've spotted few lines in drivers/bus/fslmc/.
> 
> And more importantly, we must switch to the new dynamic types
> using rte_log_register().
> 

(*)
ok. In which case, this patch would become redundant. I will add support for this in dpaa (and dpaa2 driver, next).

-
Shreyansh
diff mbox

Patch

diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index 3419138..1e45e87 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -87,6 +87,7 @@  extern struct rte_logs rte_logs;
 #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
 #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
 #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
+#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
 
 /* these log types can be used in an application */
 #define RTE_LOGTYPE_USER1     24 /**< User-defined log type 1. */