diff mbox

[dpdk-dev,v7,15/17] lib: make v20 header file private

Message ID 1487647073-129064-16-git-send-email-david.hunt@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Hunt, David Feb. 21, 2017, 3:17 a.m. UTC 
  Signed-off-by: David Hunt <david.hunt@intel.com>
---
 lib/librte_distributor/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bruce Richardson Feb. 24, 2017, 2:18 p.m. UTC | #1 
On Tue, Feb 21, 2017 at 03:17:51AM +0000, David Hunt wrote:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  lib/librte_distributor/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
> index 5b599c6..3017398 100644
> --- a/lib/librte_distributor/Makefile
> +++ b/lib/librte_distributor/Makefile
> @@ -53,8 +53,7 @@ endif
>  
>  
>  # install this header file
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor_v20.h
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
>  

Minor nits:
1/ I think this patch should go earlier in the set.
2/ you can keep the += in the assignment. It actually makes it less
error prone for anyone changing/adding things later as they can
copy-paste or reorder the lines without causing themselves problems.

/Bruce
diff mbox

Patch

diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
index 5b599c6..3017398 100644
--- a/lib/librte_distributor/Makefile
+++ b/lib/librte_distributor/Makefile
@@ -53,8 +53,7 @@  endif
 
 
 # install this header file
-SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor_v20.h
-SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor.h
+SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
 
 # this lib needs eal
 DEPDIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += lib/librte_eal