| Message ID | 1483551207-18236-3-git-send-email-zbigniew.bodek@caviumnetworks.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Pablo de Lara Guarch |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel compilation | success | Compilation OK |
On 1/4/2017 11:03 PM, zbigniew.bodek@caviumnetworks.com wrote: > From: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> > > Add type and name for ARMv8 crypto PMD > > Signed-off-by: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> > --- > lib/librte_cryptodev/rte_cryptodev.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > index 8f63e8f..6f34f22 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -66,6 +66,8 @@ > /**< KASUMI PMD device name */ > #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc > /**< KASUMI PMD device name */ > +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 > +/**< ARMv8 Crypto PMD device name */ > I will suggest the name as armv8ce or armv8_ce for this driver. Do you agree? > /** Crypto device type */ > enum rte_cryptodev_type { > @@ -77,6 +79,7 @@ enum rte_cryptodev_type { > RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ > RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ > RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ > + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ > }; > > extern const char **rte_cyptodev_names; >
On 13.01.2017 09:16, Hemant Agrawal wrote: > On 1/4/2017 11:03 PM, zbigniew.bodek@caviumnetworks.com wrote: >> From: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> >> >> Add type and name for ARMv8 crypto PMD >> >> Signed-off-by: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> >> --- >> lib/librte_cryptodev/rte_cryptodev.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >> b/lib/librte_cryptodev/rte_cryptodev.h >> index 8f63e8f..6f34f22 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.h >> +++ b/lib/librte_cryptodev/rte_cryptodev.h >> @@ -66,6 +66,8 @@ >> /**< KASUMI PMD device name */ >> #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc >> /**< KASUMI PMD device name */ >> +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 >> +/**< ARMv8 Crypto PMD device name */ >> > I will suggest the name as armv8ce or armv8_ce for this driver. > Do you agree? CE for "crypto extensions"? Agreed. > >> /** Crypto device type */ >> enum rte_cryptodev_type { >> @@ -77,6 +79,7 @@ enum rte_cryptodev_type { >> RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ >> RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ >> RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ >> + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ >> }; >> >> extern const char **rte_cyptodev_names; >> > >
On 13 January 2017 at 16:16, Hemant Agrawal <hemant.agrawal@nxp.com> wrote: > On 1/4/2017 11:03 PM, zbigniew.bodek@caviumnetworks.com wrote: >> >> From: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> >> >> Add type and name for ARMv8 crypto PMD >> >> Signed-off-by: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com> >> --- >> lib/librte_cryptodev/rte_cryptodev.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >> b/lib/librte_cryptodev/rte_cryptodev.h >> index 8f63e8f..6f34f22 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.h >> +++ b/lib/librte_cryptodev/rte_cryptodev.h >> @@ -66,6 +66,8 @@ >> /**< KASUMI PMD device name */ >> #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc >> /**< KASUMI PMD device name */ >> +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 >> +/**< ARMv8 Crypto PMD device name */ >> > I will suggest the name as armv8ce or armv8_ce for this driver. > Do you agree? > I don't because it's a lib only optimized for chained crypto and hash. > >> /** Crypto device type */ >> enum rte_cryptodev_type { >> @@ -77,6 +79,7 @@ enum rte_cryptodev_type { >> RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ >> RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ >> RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ >> + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ >> }; >> >> extern const char **rte_cyptodev_names; >> > >
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 8f63e8f..6f34f22 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -66,6 +66,8 @@ /**< KASUMI PMD device name */ #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc /**< KASUMI PMD device name */ +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 +/**< ARMv8 Crypto PMD device name */ /** Crypto device type */ enum rte_cryptodev_type { @@ -77,6 +79,7 @@ enum rte_cryptodev_type { RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ }; extern const char **rte_cyptodev_names;