[dpdk-dev] net/virtio-user: fix missing default macro

Message ID 1467170406-137615-1-git-send-email-jianfeng.tan@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Commit Message

Jianfeng Tan June 29, 2016, 3:20 a.m. UTC
  With current config structure, all configuration parameters put into
common_base with a default value, and overwritten in environment file
if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.

This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
macro value.

Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")

Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 config/common_base | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Yuanhan Liu July 1, 2016, 2:05 a.m. UTC | #1
On Wed, Jun 29, 2016 at 03:20:06AM +0000, Jianfeng Tan wrote:
> With current config structure, all configuration parameters put into
> common_base with a default value, and overwritten in environment file
> if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.
> 
> This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
> macro value.
> 
> Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  config/common_base | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index 5d9daf5..0368d59 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -269,6 +269,11 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
>  
>  #
> +# Compile software VIRTIO-USER PMD driver

I will not call it "PMD driver", instead, I'd say "virtio device
emulation inside virtio PMD".

Fixed and applied to dpdk-next-virtio.

	--yliu

> +#
> +CONFIG_RTE_VIRTIO_USER=n
> +
> +#
>  # Compile burst-oriented VMXNET3 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_VMXNET3_PMD=y
> -- 
> 2.1.4
  

Patch

diff --git a/config/common_base b/config/common_base
index 5d9daf5..0368d59 100644
--- a/config/common_base
+++ b/config/common_base
@@ -269,6 +269,11 @@  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
 
 #
+# Compile software VIRTIO-USER PMD driver
+#
+CONFIG_RTE_VIRTIO_USER=n
+
+#
 # Compile burst-oriented VMXNET3 PMD driver
 #
 CONFIG_RTE_LIBRTE_VMXNET3_PMD=y