[dpdk-dev,v1,09/28] eal: introduce --no-soc option

  This option has the same meaning for the SoC infra as the --no-pci
for the PCI infra.

Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
---
 lib/librte_eal/common/eal_common_options.c | 5 +++++
 lib/librte_eal/common/eal_internal_cfg.h   | 1 +
 lib/librte_eal/common/eal_options.h        | 2 ++
 3 files changed, 8 insertions(+)
  

On 6 May 2016 at 21:47, Jan Viktorin <viktorin@rehivetech.com> wrote:
> This option has the same meaning for the SoC infra as the --no-pci
> for the PCI infra.
>
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  lib/librte_eal/common/eal_common_options.c | 5 +++++
>  lib/librte_eal/common/eal_internal_cfg.h   | 1 +
>  lib/librte_eal/common/eal_options.h        | 2 ++
>  3 files changed, 8 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 3efc90f..09d64f7 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -85,6 +85,7 @@ eal_long_options[] = {
>         {OPT_NO_HPET,           0, NULL, OPT_NO_HPET_NUM          },
>         {OPT_NO_HUGE,           0, NULL, OPT_NO_HUGE_NUM          },
>         {OPT_NO_PCI,            0, NULL, OPT_NO_PCI_NUM           },
> +       {OPT_NO_SOC,            0, NULL, OPT_NO_SOC_NUM           },
>         {OPT_NO_SHCONF,         0, NULL, OPT_NO_SHCONF_NUM        },
>         {OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },
>         {OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },
> @@ -841,6 +842,10 @@ eal_parse_common_option(int opt, const char *optarg,
>                 conf->no_pci = 1;
>                 break;
>
> +       case OPT_NO_SOC_NUM:
> +               conf->no_soc = 1;

Could it be better to rename to enable_soc, and disable soc by default?

> +               break;
> +
>         case OPT_NO_HPET_NUM:
>                 conf->no_hpet = 1;
>                 break;
> diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h
> index 5f1367e..3a98e94 100644
> --- a/lib/librte_eal/common/eal_internal_cfg.h
> +++ b/lib/librte_eal/common/eal_internal_cfg.h
> @@ -67,6 +67,7 @@ struct internal_config {
>         unsigned hugepage_unlink;         /**< true to unlink backing files */
>         volatile unsigned xen_dom0_support; /**< support app running on Xen Dom0*/
>         volatile unsigned no_pci;         /**< true to disable PCI */
> +       volatile unsigned no_soc;         /**< true to disable SoC */
>         volatile unsigned no_hpet;        /**< true to disable HPET */
>         volatile unsigned vmware_tsc_map; /**< true to use VMware TSC mapping
>                                                                                 * instead of native TSC */
> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
> index a881c62..ba1e704 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -69,6 +69,8 @@ enum {
>         OPT_NO_HUGE_NUM,
>  #define OPT_NO_PCI            "no-pci"
>         OPT_NO_PCI_NUM,
> +#define OPT_NO_SOC            "no-soc"
> +       OPT_NO_SOC_NUM,
>  #define OPT_NO_SHCONF         "no-shconf"
>         OPT_NO_SHCONF_NUM,
>  #define OPT_SOCKET_MEM        "socket-mem"
> --
> 2.8.0
>
  

On Fri, 13 May 2016 11:28:18 +0800
Jianbo Liu <jianbo.liu@linaro.org> wrote:

> On 6 May 2016 at 21:47, Jan Viktorin <viktorin@rehivetech.com> wrote:
> > This option has the same meaning for the SoC infra as the --no-pci
> > for the PCI infra.
> >
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> >  lib/librte_eal/common/eal_common_options.c | 5 +++++
> >  lib/librte_eal/common/eal_internal_cfg.h   | 1 +
> >  lib/librte_eal/common/eal_options.h        | 2 ++
> >  3 files changed, 8 insertions(+)
> >
> > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> > index 3efc90f..09d64f7 100644
> > --- a/lib/librte_eal/common/eal_common_options.c
> > +++ b/lib/librte_eal/common/eal_common_options.c
> > @@ -85,6 +85,7 @@ eal_long_options[] = {
> >         {OPT_NO_HPET,           0, NULL, OPT_NO_HPET_NUM          },
> >         {OPT_NO_HUGE,           0, NULL, OPT_NO_HUGE_NUM          },
> >         {OPT_NO_PCI,            0, NULL, OPT_NO_PCI_NUM           },
> > +       {OPT_NO_SOC,            0, NULL, OPT_NO_SOC_NUM           },
> >         {OPT_NO_SHCONF,         0, NULL, OPT_NO_SHCONF_NUM        },
> >         {OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },
> >         {OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },
> > @@ -841,6 +842,10 @@ eal_parse_common_option(int opt, const char *optarg,
> >                 conf->no_pci = 1;
> >                 break;
> >
> > +       case OPT_NO_SOC_NUM:
> > +               conf->no_soc = 1;  
> 
> Could it be better to rename to enable_soc, and disable soc by default?

Sure, I tried to be consistent with PCI...

[...]