[dpdk-dev] examples/ip_pipeline: fix out-of-bounds write

Message ID 1460627627-1990-1-git-send-email-marcinx.kerlin@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Marcin Kerlin April 14, 2016, 9:53 a.m. UTC
  CID 124567:
In the function app_init_eal(struct app params * app) number of 
entries into array exceeds the size of the array if the conditions 
are fulfilled.

Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")

Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
---
 examples/ip_pipeline/app.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Cristian Dumitrescu April 28, 2016, 10:49 a.m. UTC | #1
> -----Original Message-----
> From: Kerlin, MarcinX
> Sent: Thursday, April 14, 2016 10:54 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Kerlin, MarcinX
> <marcinx.kerlin@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix out-of-bounds write
> 
> CID 124567:
> In the function app_init_eal(struct app params * app) number of
> entries into array exceeds the size of the array if the conditions
> are fulfilled.
> 
> Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
> 
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> ---
>  examples/ip_pipeline/app.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
> index 55a9841..e775024 100644
> --- a/examples/ip_pipeline/app.h
> +++ b/examples/ip_pipeline/app.h
> @@ -415,7 +415,7 @@ struct app_eal_params {
>  #endif
> 
>  #ifndef APP_EAL_ARGC
> -#define APP_EAL_ARGC                             32
> +#define APP_EAL_ARGC                             64
>  #endif
> 
>  #ifndef APP_MAX_PIPELINE_TYPES
> --
> 1.9.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
  
Thomas Monjalon May 16, 2016, 5:32 p.m. UTC | #2
> > CID 124567:
> > In the function app_init_eal(struct app params * app) number of
> > entries into array exceeds the size of the array if the conditions
> > are fulfilled.
> > 
> > Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
> > 
> > Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
index 55a9841..e775024 100644
--- a/examples/ip_pipeline/app.h
+++ b/examples/ip_pipeline/app.h
@@ -415,7 +415,7 @@  struct app_eal_params {
 #endif
 
 #ifndef APP_EAL_ARGC
-#define APP_EAL_ARGC                             32
+#define APP_EAL_ARGC                             64
 #endif
 
 #ifndef APP_MAX_PIPELINE_TYPES