diff mbox

[dpdk-dev] pci: fix bsd build with gcc

Message ID 1438698465-27834-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon Aug. 4, 2015, 2:27 p.m. UTC 
  GCC 4.8 raises this error:
lib/librte_eal/bsdapp/eal/eal_pci.c:453:15: error: cast discards
'__attribute__((const))' qualifier from pointer target type
   .pi_data = *(u_int32_t *)buf,
               ^

Note: this assignment seems useless because pi_data is filled
with memset later.

Fixes: 632b2d1deeed ("eal: provide functions to access PCI config")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Aug. 4, 2015, 3:05 p.m. UTC | #1 
On Tue, Aug 04, 2015 at 04:27:45PM +0200, Thomas Monjalon wrote:
> GCC 4.8 raises this error:
> lib/librte_eal/bsdapp/eal/eal_pci.c:453:15: error: cast discards
> '__attribute__((const))' qualifier from pointer target type
>    .pi_data = *(u_int32_t *)buf,
>                ^
> 
> Note: this assignment seems useless because pi_data is filled
> with memset later.
> 
> Fixes: 632b2d1deeed ("eal: provide functions to access PCI config")
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Aug. 4, 2015, 3:10 p.m. UTC | #2 
2015-08-04 16:05, Bruce Richardson:
> On Tue, Aug 04, 2015 at 04:27:45PM +0200, Thomas Monjalon wrote:
> > GCC 4.8 raises this error:
> > lib/librte_eal/bsdapp/eal/eal_pci.c:453:15: error: cast discards
> > '__attribute__((const))' qualifier from pointer target type
> >    .pi_data = *(u_int32_t *)buf,
> >                ^
> > 
> > Note: this assignment seems useless because pi_data is filled
> > with memset later.
> > 
> > Fixes: 632b2d1deeed ("eal: provide functions to access PCI config")
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied
diff mbox

Patch

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 6fa0d08..6c21fbd 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -450,7 +450,7 @@  int rte_eal_pci_write_config(const struct rte_pci_device *dev,
 			.pc_func = dev->addr.function,
 		},
 		.pi_reg = offset,
-		.pi_data = *(u_int32_t *)buf,
+		.pi_data = *(const uint32_t *)buf,
 		.pi_width = len,
 	};