diff mbox

[dpdk-dev] testpmd: Fix segment fault when port ID greater than 76

Message ID 1438108335-10093-1-git-send-email-michael.qiu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Michael Qiu July 28, 2015, 6:32 p.m. UTC 
  In testpmd, when using "rx_vlan add 1 77", it will be a segment fault
Because the port ID should be less than 32.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon July 29, 2015, 9:45 p.m. UTC | #1 
2015-07-29 02:32, Michael Qiu:
> In testpmd, when using "rx_vlan add 1 77", it will be a segment fault
> Because the port ID should be less than 32.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>

Fixes: edab33b1c01d ("app/testpmd: support port hotplug")

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 1d29146..cf2aa6e 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -388,7 +388,7 @@  port_id_is_invalid(portid_t port_id, enum print_warning warning)
 	if (port_id == (portid_t)RTE_PORT_ALL)
 		return 0;
 
-	if (ports[port_id].enabled)
+	if (port_id < RTE_MAX_ETHPORTS && ports[port_id].enabled)
 		return 0;
 
 	if (warning == ENABLED_WARN)