diff mbox

[dpdk-dev] config: disable bnx2x driver

Message ID 1438103799-31340-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon July 28, 2015, 5:16 p.m. UTC 
  This driver has too many issues:
	- too big
	- bad coding style
	- no git history (dropped in 2 patches)
	- no documentation
	- no BSD support
	- no maintainer
And the biggest one, constraining this disabling:
	- many build issues

If the last 4 issues are not fixed in the next release 2.2,
the driver must be removed.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 config/common_linuxapp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger July 28, 2015, 6:29 p.m. UTC | #1 
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> This driver has too many issues:
> 	- too big
> 	- bad coding style
> 	- no git history (dropped in 2 patches)
> 	- no documentation
> 	- no BSD support

The main issue with BSD is loading the firmware.
Probably just need to change the path.
Thomas Monjalon July 28, 2015, 9:17 p.m. UTC | #2 
2015-07-28 19:16, Thomas Monjalon:
> This driver has too many issues:
> 	- too big
> 	- bad coding style
> 	- no git history (dropped in 2 patches)
> 	- no documentation
> 	- no BSD support
> 	- no maintainer
> And the biggest one, constraining this disabling:
> 	- many build issues
> 
> If the last 4 issues are not fixed in the next release 2.2,
> the driver must be removed.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied
Stephen Hemminger July 28, 2015, 9:38 p.m. UTC | #3 
On Tue, 28 Jul 2015 19:16:39 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> This driver has too many issues:
> 	- too big

FYI - the DPDK version of the driver is already much smaller
than other OS. Still all versions seem to be bigger than necessary
but that is what vendor code looks like.

	Driver	LOC
	bnx2x	37973
	ixgbe	27017
	i40e	25234

In FreeBSD
	ixgbe	23834
	bxe	160464

In Linux
	ixgbe	25146
	i40e	28753
	bnx2x	55395
diff mbox

Patch

diff --git a/config/common_linuxapp b/config/common_linuxapp
index 72373b6..bda9a63 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -214,7 +214,7 @@  CONFIG_RTE_LIBRTE_MLX4_SOFT_COUNTERS=1
 #
 # Compile burst-oriented Broadcom PMD driver
 #
-CONFIG_RTE_LIBRTE_BNX2X_PMD=y
+CONFIG_RTE_LIBRTE_BNX2X_PMD=n
 CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n
 CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=n
 CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=n