diff mbox

[dpdk-dev,v3,2/6] ixgbe: raise priority of significant log events

Message ID 1436482868-7400-3-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger July 9, 2015, 11:01 p.m. UTC 
  From: Stephen Hemminger <shemming@brocade.com>

Customers often screen off info level messages, so raise log
level of significant events

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++------
 drivers/net/ixgbe/ixgbe_fdir.c   |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Thomas Monjalon July 9, 2015, 11:27 p.m. UTC | #1 
2015-07-09 16:01, Stephen Hemminger:
> From: Stephen Hemminger <shemming@brocade.com>
> 
> Customers often screen off info level messages, so raise log
> level of significant events
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

It was acked by Bruce with a (not addressed) comment:
http://dpdk.org/ml/archives/dev/2015-May/017785.html
Stephen Hemminger July 9, 2015, 11:39 p.m. UTC | #2 
On Fri, 10 Jul 2015 01:27:25 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-07-09 16:01, Stephen Hemminger:
> > From: Stephen Hemminger <shemming@brocade.com>
> > 
> > Customers often screen off info level messages, so raise log
> > level of significant events
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> It was acked by Bruce with a (not addressed) comment:
> http://dpdk.org/ml/archives/dev/2015-May/017785.html
> 

His comment was:

> Should we not fix the text here to be "82599EB does not support ..." while we
> are making this change? (Same with next chunk below too).

I prefer not to change the text of the messages in the same patch set.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 0ff9583..ba98dd7 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -759,8 +759,8 @@  eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)
 			ixgbe_set_tx_function(eth_dev, txq);
 		} else {
 			/* Use default TX function if we get here */
-			PMD_INIT_LOG(INFO, "No TX queues configured yet. "
-			                   "Using default TX function.");
+			PMD_INIT_LOG(NOTICE, "No TX queues configured yet. "
+				     "Using default TX function.");
 		}
 
 		ixgbe_set_rx_function(eth_dev);
@@ -1256,7 +1256,7 @@  ixgbe_vlan_hw_strip_disable(struct rte_eth_dev *dev, uint16_t queue)
 
 	if (hw->mac.type == ixgbe_mac_82598EB) {
 		/* No queue level support */
-		PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip");
+		PMD_INIT_LOG(NOTICE, "82598EB not support queue level hw strip");
 		return;
 	}
 	else {
@@ -1280,7 +1280,7 @@  ixgbe_vlan_hw_strip_enable(struct rte_eth_dev *dev, uint16_t queue)
 
 	if (hw->mac.type == ixgbe_mac_82598EB) {
 		/* No queue level supported */
-		PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip");
+		PMD_INIT_LOG(NOTICE, "82598EB not support queue level hw strip");
 		return;
 	}
 	else {
@@ -2981,12 +2981,12 @@  ixgbevf_dev_configure(struct rte_eth_dev *dev)
 	 */
 #ifndef RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC
 	if (!conf->rxmode.hw_strip_crc) {
-		PMD_INIT_LOG(INFO, "VF can't disable HW CRC Strip");
+		PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip");
 		conf->rxmode.hw_strip_crc = 1;
 	}
 #else
 	if (conf->rxmode.hw_strip_crc) {
-		PMD_INIT_LOG(INFO, "VF can't enable HW CRC Strip");
+		PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip");
 		conf->rxmode.hw_strip_crc = 0;
 	}
 #endif
diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index d294f85..5c8b833 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -377,7 +377,7 @@  ixgbe_set_fdir_flex_conf(struct rte_eth_dev *dev,
 	fdirm = IXGBE_READ_REG(hw, IXGBE_FDIRM);
 
 	if (conf == NULL) {
-		PMD_DRV_LOG(INFO, "NULL pointer.");
+		PMD_DRV_LOG(ERR, "NULL pointer.");
 		return -EINVAL;
 	}