| Message ID | 1433502340-14725-1-git-send-email-bruce.richardson@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 056BB5A35; Fri, 5 Jun 2015 13:05:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 43AF15A0F for <dev@dpdk.org>; Fri, 5 Jun 2015 13:05:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 05 Jun 2015 04:05:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,558,1427785200"; d="scan'208";a="503194942" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 05 Jun 2015 04:05:41 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t55B5ekq031940; Fri, 5 Jun 2015 12:05:40 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t55B5eka014764; Fri, 5 Jun 2015 12:05:40 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t55B5eeB014760; Fri, 5 Jun 2015 12:05:40 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Date: Fri, 5 Jun 2015 12:05:40 +0100 Message-Id: <1433502340-14725-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Bruce Richardson
June 5, 2015, 11:05 a.m. UTC
On Fedora 22, the "ar" binary operates by default in deterministic mode,
making the "u" parameter irrelevant, and leading to warning messages
getting printed in the build output like below.
INSTALL-LIB librte_kvargs.a
ar: `u' modifier ignored since `D' is the default (see `U')
There are two options to remove these warnings:
* add in the "U" flag to make "ar" non-deterministic again
* remove the "u" flag to have all objects always updated
This patch takes the second approach.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
mk/rte.lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Bruce, On 06/05/2015 01:05 PM, Bruce Richardson wrote: > On Fedora 22, the "ar" binary operates by default in deterministic mode, > making the "u" parameter irrelevant, and leading to warning messages > getting printed in the build output like below. > > INSTALL-LIB librte_kvargs.a > ar: `u' modifier ignored since `D' is the default (see `U') > > There are two options to remove these warnings: > * add in the "U" flag to make "ar" non-deterministic again > * remove the "u" flag to have all objects always updated Indeed, I think that removing 'u' won't have any impact in this case, as we always regenerate the full archive without updating it. However, why not explicitly use 'D' to have the same behavior across distributions? Regards, Olivier > > This patch takes the second approach. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > mk/rte.lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > index 0d7482d..6bd67aa 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -70,7 +70,7 @@ else > _CPU_LDFLAGS := $(CPU_LDFLAGS) > endif > > -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) > +O_TO_A = $(AR) crs $(LIB) $(OBJS-y) > O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight > O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") > O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)" >
On Mon, Jun 08, 2015 at 10:13:30AM +0200, Olivier MATZ wrote: > Hi Bruce, > > On 06/05/2015 01:05 PM, Bruce Richardson wrote: > > On Fedora 22, the "ar" binary operates by default in deterministic mode, > > making the "u" parameter irrelevant, and leading to warning messages > > getting printed in the build output like below. > > > > INSTALL-LIB librte_kvargs.a > > ar: `u' modifier ignored since `D' is the default (see `U') > > > > There are two options to remove these warnings: > > * add in the "U" flag to make "ar" non-deterministic again > > * remove the "u" flag to have all objects always updated > > Indeed, I think that removing 'u' won't have any impact in this case, > as we always regenerate the full archive without updating it. > However, why not explicitly use 'D' to have the same behavior across > distributions? > > Regards, > Olivier > Good question. I didn't bother adding in the "D" flag as I didn't see the need. [Basically, I asked "why" instead of "why not" :-)] However, if folks think it's worthwhile doing, I don't think doing a V2 of this patch would tax me unduly :-) /Bruce > > > > > This patch takes the second approach. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > --- > > mk/rte.lib.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > > index 0d7482d..6bd67aa 100644 > > --- a/mk/rte.lib.mk > > +++ b/mk/rte.lib.mk > > @@ -70,7 +70,7 @@ else > > _CPU_LDFLAGS := $(CPU_LDFLAGS) > > endif > > > > -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) > > +O_TO_A = $(AR) crs $(LIB) $(OBJS-y) > > O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight > > O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") > > O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)" > >
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 0d7482d..6bd67aa 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -70,7 +70,7 @@ else _CPU_LDFLAGS := $(CPU_LDFLAGS) endif -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) +O_TO_A = $(AR) crs $(LIB) $(OBJS-y) O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"