[dpdk-dev] eal/bsd: fix return value when mapping device resources in secondary process

Message ID 1414671819-29319-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

De Lara Guarch, Pablo Oct. 30, 2014, 12:23 p.m. UTC
  On FreeBSD, when initializing a secondary process,
EAL was complaining if there were ports not bound
to nic_uio module, exiting the application, which
should not happen, as this is expected behaviour,
and not an error

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
  

Comments

Thomas Monjalon Nov. 5, 2014, 9:51 p.m. UTC | #1
> On FreeBSD, when initializing a secondary process,
> EAL was complaining if there were ports not bound
> to nic_uio module, exiting the application, which
> should not happen, as this is expected behaviour,
> and not an error
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
  

Patch

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 54fcaf0..74ecce7 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -183,7 +183,7 @@  pci_uio_map_secondary(struct rte_pci_device *dev)
 	}
 
 	RTE_LOG(ERR, EAL, "Cannot find resource for device\n");
-	return -1;
+	return 1;
 }
 
 /* map the PCI resource of a PCI device in virtual memory */