mbox series

[v2,0/4] net/cxgbe: fix build for Microsoft Windows OS support

Message ID cover.1545236474.git.rahul.lakkireddy@chelsio.com (mailing list archive)
Headers
Series net/cxgbe: fix build for Microsoft Windows OS support |

Message

Rahul Lakkireddy Dec. 19, 2018, 4:28 p.m. UTC 
  This series of patches fix compilation warning and errors seen while
building CXGBE PMD in preparation for Microsoft Windows OS support.

Patch 1 uses relative paths for including header files.
Patch 2 fixes macros related to rte_log().
Patch 3 only redefines symbols when they are not available.
Patch 4 fixes other misc build issues.

Patches are generated against dpdk-next-net tree.

Build Environment:
1. Target OS: Microsoft Windows Server 2016
2. Compiler: Intel C++ Compiler v19 from Intel Parallel Studio XE 2019 [1]
3. Development Tools:
   3.1 Microsoft Visual Studio 2017 Professional
   3.2 Windows Software Development Kit (SDK) v10.0.17763
   3.3 Windows Driver Kit (WDK) v10.0.17763

[1] https://software.intel.com/en-us/parallel-studio-xe

Thanks,
Rahul

---
v2:
- Add more info in commit message regarding Windows build.

Rahul Lakkireddy (4):
  net/cxgbe: use relative paths for including header files
  net/cxgbe: fix macros related to logs for Windows
  net/cxgbe: only define symbols when not available
  net/cxgbe: fix other misc build issues for Windows

 drivers/net/cxgbe/Makefile         |  2 -
 drivers/net/cxgbe/base/adapter.h   |  4 +-
 drivers/net/cxgbe/base/common.h    |  4 +-
 drivers/net/cxgbe/base/t4_hw.c     |  4 +-
 drivers/net/cxgbe/base/t4vf_hw.c   |  2 +-
 drivers/net/cxgbe/clip_tbl.c       |  2 +-
 drivers/net/cxgbe/cxgbe.h          |  4 +-
 drivers/net/cxgbe/cxgbe_compat.h   | 83 ++++++++++++++++++++----------
 drivers/net/cxgbe/cxgbe_ethdev.c   |  2 +-
 drivers/net/cxgbe/cxgbe_filter.c   |  7 +--
 drivers/net/cxgbe/cxgbe_filter.h   |  2 +-
 drivers/net/cxgbe/cxgbe_flow.c     |  2 +-
 drivers/net/cxgbe/cxgbe_main.c     |  6 +--
 drivers/net/cxgbe/cxgbevf_ethdev.c |  2 +-
 drivers/net/cxgbe/cxgbevf_main.c   |  6 +--
 drivers/net/cxgbe/l2t.c            |  3 +-
 drivers/net/cxgbe/l2t.h            |  2 +-
 drivers/net/cxgbe/mps_tcam.h       |  2 +-
 drivers/net/cxgbe/sge.c            |  9 ++--
 19 files changed, 90 insertions(+), 58 deletions(-)

Comments

Ferruh Yigit Dec. 19, 2018, 9:39 p.m. UTC | #1 
On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote:
> This series of patches fix compilation warning and errors seen while
> building CXGBE PMD in preparation for Microsoft Windows OS support.
> 
> Patch 1 uses relative paths for including header files.
> Patch 2 fixes macros related to rte_log().
> Patch 3 only redefines symbols when they are not available.
> Patch 4 fixes other misc build issues.
> 
> Patches are generated against dpdk-next-net tree.
> 
> Build Environment:
> 1. Target OS: Microsoft Windows Server 2016
> 2. Compiler: Intel C++ Compiler v19 from Intel Parallel Studio XE 2019 [1]
> 3. Development Tools:
>    3.1 Microsoft Visual Studio 2017 Professional
>    3.2 Windows Software Development Kit (SDK) v10.0.17763
>    3.3 Windows Driver Kit (WDK) v10.0.17763
> 
> [1] https://software.intel.com/en-us/parallel-studio-xe
> 
> Thanks,
> Rahul
> 
> ---
> v2:
> - Add more info in commit message regarding Windows build.
> 
> Rahul Lakkireddy (4):
>   net/cxgbe: use relative paths for including header files
>   net/cxgbe: fix macros related to logs for Windows
>   net/cxgbe: only define symbols when not available
>   net/cxgbe: fix other misc build issues for Windows

Series applied to dpdk-next-net/master, thanks.

Beware none of the patches has fixes lines, so they won't be backported by default.
If this wasn't the intention please provide fixes lines and I can update in tree.
Rahul Lakkireddy Dec. 20, 2018, 3:54 a.m. UTC | #2 
On Thursday, December 12/20/18, 2018 at 03:09:44 +0530, Ferruh Yigit wrote:
> On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote:
> > This series of patches fix compilation warning and errors seen while
> > building CXGBE PMD in preparation for Microsoft Windows OS support.
> > 
> > Patch 1 uses relative paths for including header files.
> > Patch 2 fixes macros related to rte_log().
> > Patch 3 only redefines symbols when they are not available.
> > Patch 4 fixes other misc build issues.
> > 
> > Patches are generated against dpdk-next-net tree.
> > 
> > Build Environment:
> > 1. Target OS: Microsoft Windows Server 2016
> > 2. Compiler: Intel C++ Compiler v19 from Intel Parallel Studio XE 2019 [1]
> > 3. Development Tools:
> >    3.1 Microsoft Visual Studio 2017 Professional
> >    3.2 Windows Software Development Kit (SDK) v10.0.17763
> >    3.3 Windows Driver Kit (WDK) v10.0.17763
> > 
> > [1] https://software.intel.com/en-us/parallel-studio-xe
> > 
> > Thanks,
> > Rahul
> > 
> > ---
> > v2:
> > - Add more info in commit message regarding Windows build.
> > 
> > Rahul Lakkireddy (4):
> >   net/cxgbe: use relative paths for including header files
> >   net/cxgbe: fix macros related to logs for Windows
> >   net/cxgbe: only define symbols when not available
> >   net/cxgbe: fix other misc build issues for Windows
> 
> Series applied to dpdk-next-net/master, thanks.
> 
> Beware none of the patches has fixes lines, so they won't be backported by default.
> If this wasn't the intention please provide fixes lines and I can update in tree.

Thanks Ferruh. I intentionally left out the fixes lines. Don't backport
these patches.

Thanks,
Rahul