mbox series

[0/7] bnxt bug fixes

Message ID 20240208171330.31139-1-ajit.khaparde@broadcom.com (mailing list archive)
Headers
Series bnxt bug fixes |

Message

Ajit Khaparde Feb. 8, 2024, 5:13 p.m. UTC 
  Patchset with bug fixes for bnxt PMD.
Patch based against the
next-net-brcm for-next-net branch.

Please apply.

Ajit Khaparde (4):
  net/bnxt: modify locking for representor Tx
  net/bnxt: refactor VNIC context cleanup
  net/bnxt: update consumer index of NQ regularly
  net/bnxt: update RSS algorithm capability

Damodharam Ammepalli (1):
  net/bnxt: cleanup vnic ref count

Kishore Padmanabha (1):
  net/bnxt: avoid seg fault in Tx queue release

Shuanglin Wang (1):
  net/bnxt: adjust session name on multi host system

 drivers/net/bnxt/bnxt.h            |  2 +-
 drivers/net/bnxt/bnxt_ethdev.c     | 14 +++-----
 drivers/net/bnxt/bnxt_hwrm.c       | 16 +++++++--
 drivers/net/bnxt/bnxt_irq.c        | 26 +++++++++++---
 drivers/net/bnxt/bnxt_reps.c       |  6 ++--
 drivers/net/bnxt/bnxt_txq.c        |  8 ++++-
 drivers/net/bnxt/bnxt_txq.h        |  1 +
 drivers/net/bnxt/bnxt_txr.c        | 13 +++++++
 drivers/net/bnxt/bnxt_txr.h        |  4 ++-
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++
 10 files changed, 125 insertions(+), 23 deletions(-)

Comments

Ajit Khaparde Feb. 8, 2024, 9:50 p.m. UTC | #1 
On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
>
> Patchset with bug fixes for bnxt PMD.
> Patch based against the
> next-net-brcm for-next-net branch.
>
> Please apply.
Patchset merged to the dpdk-next-brcm for-next-net branch.
Thanks

>
> Ajit Khaparde (4):
>   net/bnxt: modify locking for representor Tx
>   net/bnxt: refactor VNIC context cleanup
>   net/bnxt: update consumer index of NQ regularly
>   net/bnxt: update RSS algorithm capability
>
> Damodharam Ammepalli (1):
>   net/bnxt: cleanup vnic ref count
>
> Kishore Padmanabha (1):
>   net/bnxt: avoid seg fault in Tx queue release
>
> Shuanglin Wang (1):
>   net/bnxt: adjust session name on multi host system
>
>  drivers/net/bnxt/bnxt.h            |  2 +-
>  drivers/net/bnxt/bnxt_ethdev.c     | 14 +++-----
>  drivers/net/bnxt/bnxt_hwrm.c       | 16 +++++++--
>  drivers/net/bnxt/bnxt_irq.c        | 26 +++++++++++---
>  drivers/net/bnxt/bnxt_reps.c       |  6 ++--
>  drivers/net/bnxt/bnxt_txq.c        |  8 ++++-
>  drivers/net/bnxt/bnxt_txq.h        |  1 +
>  drivers/net/bnxt/bnxt_txr.c        | 13 +++++++
>  drivers/net/bnxt/bnxt_txr.h        |  4 ++-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++
>  10 files changed, 125 insertions(+), 23 deletions(-)
>
> --
> 2.39.2 (Apple Git-143)
>
Patrick Robb Feb. 22, 2024, 2:50 a.m. UTC | #2 
https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khaparde@broadcom.com/

Hi Ajit,

So you know, this series did fail in CI testing, and now that it is merged
to main, all patchseries are failing DTS at EAL. Performance testing is
also offline for the same reason.

I will run the niccli utility to upgrade broadcom NIC firmware on the
system and give it a rerun. Otherwise, let me know what you think.

This occurs on our ARM Ampere server, with the BCM57414 NetXtreme-E
10Gb/25Gb

21:02:08   [00;36m                   TestScatter: Test Case
test_scatter_mbuf_2048 Begin [0m
21:02:08  dut.arm-ampere-dut.dpdklab.iol.unh.edu:
x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a
0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854   -- -i
--mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000
--port-topology=loop --tx-offloads=0x00008000 [0m
21:04:14   [01;31m                   TestScatter: Test Case
test_scatter_mbuf_2048 Result FAILED: TIMEOUT on
x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a
0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854   -- -i
--mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000
--port-topology=loop --tx-offloads=0x00008000 [0m
21:04:14   [01;31m                   TestScatter: EAL: Detected CPU lcores:
160
21:04:14  EAL: Detected NUMA nodes: 2
21:04:14  EAL: Detected static linkage of DPDK
21:04:14  EAL: Multi-process socket
/var/run/dpdk/dpdk_2978774_20240222015854/mp_socket
21:04:14  EAL: Selected IOVA mode 'VA'
21:04:14  EAL: VFIO support initialized
21:04:14  EAL: Using IOMMU type 1 (Type 1)
21:04:14  EAL: Probe PCI driver: net_bnxt (14e4:16d7) device: 0007:01:00.0
(socket 1)
21:04:14  Segmentation fault (core dumped)

I'll let you know how reruns go.

On Thu, Feb 8, 2024 at 4:51 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

> On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com>
> wrote:
> >
> > Patchset with bug fixes for bnxt PMD.
> > Patch based against the
> > next-net-brcm for-next-net branch.
> >
> > Please apply.
> Patchset merged to the dpdk-next-brcm for-next-net branch.
> Thanks
>
> >
> > Ajit Khaparde (4):
> >   net/bnxt: modify locking for representor Tx
> >   net/bnxt: refactor VNIC context cleanup
> >   net/bnxt: update consumer index of NQ regularly
> >   net/bnxt: update RSS algorithm capability
> >
> > Damodharam Ammepalli (1):
> >   net/bnxt: cleanup vnic ref count
> >
> > Kishore Padmanabha (1):
> >   net/bnxt: avoid seg fault in Tx queue release
> >
> > Shuanglin Wang (1):
> >   net/bnxt: adjust session name on multi host system
> >
> >  drivers/net/bnxt/bnxt.h            |  2 +-
> >  drivers/net/bnxt/bnxt_ethdev.c     | 14 +++-----
> >  drivers/net/bnxt/bnxt_hwrm.c       | 16 +++++++--
> >  drivers/net/bnxt/bnxt_irq.c        | 26 +++++++++++---
> >  drivers/net/bnxt/bnxt_reps.c       |  6 ++--
> >  drivers/net/bnxt/bnxt_txq.c        |  8 ++++-
> >  drivers/net/bnxt/bnxt_txq.h        |  1 +
> >  drivers/net/bnxt/bnxt_txr.c        | 13 +++++++
> >  drivers/net/bnxt/bnxt_txr.h        |  4 ++-
> >  drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++
> >  10 files changed, 125 insertions(+), 23 deletions(-)
> >
> > --
> > 2.39.2 (Apple Git-143)
> >
>
Ajit Khaparde Feb. 22, 2024, 3:20 a.m. UTC | #3 
On Wed, Feb 21, 2024 at 6:50 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khaparde@broadcom.com/
>
> Hi Ajit,
>
> So you know, this series did fail in CI testing, and now that it is merged to main, all patchseries are failing DTS at EAL. Performance testing is also offline for the same reason.
>
> I will run the niccli utility to upgrade broadcom NIC firmware on the system and give it a rerun. Otherwise, let me know what you think.
>
> This occurs on our ARM Ampere server, with the BCM57414 NetXtreme-E 10Gb/25Gb
>
> 21:02:08   [00;36m                   TestScatter: Test Case test_scatter_mbuf_2048 Begin [0m
> 21:02:08  dut.arm-ampere-dut.dpdklab.iol.unh.edu: x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854   -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m
> 21:04:14   [01;31m                   TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: TIMEOUT on x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854   -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m
> 21:04:14   [01;31m                   TestScatter: EAL: Detected CPU lcores: 160
> 21:04:14  EAL: Detected NUMA nodes: 2
> 21:04:14  EAL: Detected static linkage of DPDK
> 21:04:14  EAL: Multi-process socket /var/run/dpdk/dpdk_2978774_20240222015854/mp_socket
> 21:04:14  EAL: Selected IOVA mode 'VA'
> 21:04:14  EAL: VFIO support initialized
> 21:04:14  EAL: Using IOMMU type 1 (Type 1)
> 21:04:14  EAL: Probe PCI driver: net_bnxt (14e4:16d7) device: 0007:01:00.0 (socket 1)
> 21:04:14  Segmentation fault (core dumped)
>
> I'll let you know how reruns go.

Ok Thanks for bringing it to my attention. Let me know how the rerun goes.
I had run the tests on my ARM setup and did not see the problem.
Let me try again.

Thanks
Ajit



>
> On Thu, Feb 8, 2024 at 4:51 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
>>
>> On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
>> >
>> > Patchset with bug fixes for bnxt PMD.
>> > Patch based against the
>> > next-net-brcm for-next-net branch.
>> >
>> > Please apply.
>> Patchset merged to the dpdk-next-brcm for-next-net branch.
>> Thanks
>>
>> >
>> > Ajit Khaparde (4):
>> >   net/bnxt: modify locking for representor Tx
>> >   net/bnxt: refactor VNIC context cleanup
>> >   net/bnxt: update consumer index of NQ regularly
>> >   net/bnxt: update RSS algorithm capability
>> >
>> > Damodharam Ammepalli (1):
>> >   net/bnxt: cleanup vnic ref count
>> >
>> > Kishore Padmanabha (1):
>> >   net/bnxt: avoid seg fault in Tx queue release
>> >
>> > Shuanglin Wang (1):
>> >   net/bnxt: adjust session name on multi host system
>> >
>> >  drivers/net/bnxt/bnxt.h            |  2 +-
>> >  drivers/net/bnxt/bnxt_ethdev.c     | 14 +++-----
>> >  drivers/net/bnxt/bnxt_hwrm.c       | 16 +++++++--
>> >  drivers/net/bnxt/bnxt_irq.c        | 26 +++++++++++---
>> >  drivers/net/bnxt/bnxt_reps.c       |  6 ++--
>> >  drivers/net/bnxt/bnxt_txq.c        |  8 ++++-
>> >  drivers/net/bnxt/bnxt_txq.h        |  1 +
>> >  drivers/net/bnxt/bnxt_txr.c        | 13 +++++++
>> >  drivers/net/bnxt/bnxt_txr.h        |  4 ++-
>> >  drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++
>> >  10 files changed, 125 insertions(+), 23 deletions(-)
>> >
>> > --
>> > 2.39.2 (Apple Git-143)
>> >
>
>