[v2,0/3] enhance NFP service framework

Message ID 20240202030415.739638-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series enhance NFP service framework |

Message

Chaoyong He Feb. 2, 2024, 3:04 a.m. UTC
  Make multiple devices can use single core to run services for
flower firmware.
Also add synchronize module and service module to support it.

---
v2:
* Merge the last commit of v1 into the second commit.
---

Long Wu (3):
  net/nfp: add synchronize module
  net/nfp: create new service code related files
  net/nfp: flower driver uses one service core

 drivers/net/nfp/flower/nfp_flower.c           |  56 +--
 drivers/net/nfp/flower/nfp_flower_ctrl.c      |  20 +-
 drivers/net/nfp/flower/nfp_flower_ctrl.h      |   2 +-
 .../net/nfp/flower/nfp_flower_representor.c   |   7 +
 drivers/net/nfp/flower/nfp_flower_service.c   | 196 +++++++++
 drivers/net/nfp/flower/nfp_flower_service.h   |  17 +
 drivers/net/nfp/meson.build                   |   3 +
 drivers/net/nfp/nfp_cpp_bridge.c              |  91 +----
 drivers/net/nfp/nfp_cpp_bridge.h              |   1 -
 drivers/net/nfp/nfp_ethdev.c                  |  31 +-
 drivers/net/nfp/nfp_net_common.h              |  15 +-
 drivers/net/nfp/nfp_service.c                 | 117 ++++++
 drivers/net/nfp/nfp_service.h                 |  20 +
 drivers/net/nfp/nfpcore/nfp_sync.c            | 382 ++++++++++++++++++
 drivers/net/nfp/nfpcore/nfp_sync.h            |  31 ++
 15 files changed, 854 insertions(+), 135 deletions(-)
 create mode 100644 drivers/net/nfp/flower/nfp_flower_service.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_service.h
 create mode 100644 drivers/net/nfp/nfp_service.c
 create mode 100644 drivers/net/nfp/nfp_service.h
 create mode 100644 drivers/net/nfp/nfpcore/nfp_sync.c
 create mode 100644 drivers/net/nfp/nfpcore/nfp_sync.h
  

Comments

Ferruh Yigit Feb. 6, 2024, 3:17 p.m. UTC | #1
On 2/2/2024 3:04 AM, Chaoyong He wrote:
> Make multiple devices can use single core to run services for
> flower firmware.
> Also add synchronize module and service module to support it.
> 
> ---
> v2:
> * Merge the last commit of v1 into the second commit.
>

Ask was to move the fix as first patch to make is backportable.
But by merging last (fix) commit into another one, you are completely
loosing the capability to backport it to LTS releases.

I just want to double check if this is intentionally and you don't want
to backport a fix?


> ---
> 
> Long Wu (3):
>   net/nfp: add synchronize module
>   net/nfp: create new service code related files
>   net/nfp: flower driver uses one service core
> 
>  drivers/net/nfp/flower/nfp_flower.c           |  56 +--
>  drivers/net/nfp/flower/nfp_flower_ctrl.c      |  20 +-
>  drivers/net/nfp/flower/nfp_flower_ctrl.h      |   2 +-
>  .../net/nfp/flower/nfp_flower_representor.c   |   7 +
>  drivers/net/nfp/flower/nfp_flower_service.c   | 196 +++++++++
>  drivers/net/nfp/flower/nfp_flower_service.h   |  17 +
>  drivers/net/nfp/meson.build                   |   3 +
>  drivers/net/nfp/nfp_cpp_bridge.c              |  91 +----
>  drivers/net/nfp/nfp_cpp_bridge.h              |   1 -
>  drivers/net/nfp/nfp_ethdev.c                  |  31 +-
>  drivers/net/nfp/nfp_net_common.h              |  15 +-
>  drivers/net/nfp/nfp_service.c                 | 117 ++++++
>  drivers/net/nfp/nfp_service.h                 |  20 +
>  drivers/net/nfp/nfpcore/nfp_sync.c            | 382 ++++++++++++++++++
>  drivers/net/nfp/nfpcore/nfp_sync.h            |  31 ++
>  15 files changed, 854 insertions(+), 135 deletions(-)
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_service.c
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_service.h
>  create mode 100644 drivers/net/nfp/nfp_service.c
>  create mode 100644 drivers/net/nfp/nfp_service.h
>  create mode 100644 drivers/net/nfp/nfpcore/nfp_sync.c
>  create mode 100644 drivers/net/nfp/nfpcore/nfp_sync.h
>
  
Chaoyong He Feb. 8, 2024, 9:52 a.m. UTC | #2
> On 2/2/2024 3:04 AM, Chaoyong He wrote:
> > Make multiple devices can use single core to run services for flower
> > firmware.
> > Also add synchronize module and service module to support it.
> >
> > ---
> > v2:
> > * Merge the last commit of v1 into the second commit.
> >
> 
> Ask was to move the fix as first patch to make is backportable.
> But by merging last (fix) commit into another one, you are completely loosing the
> capability to backport it to LTS releases.
> 
> I just want to double check if this is intentionally and you don't want to backport
> a fix?
> 

Yes, it's intentionally and we don't want to backport it, thanks.

> 
> > ---
> >
> > Long Wu (3):
> >   net/nfp: add synchronize module
> >   net/nfp: create new service code related files
> >   net/nfp: flower driver uses one service core
> >
> >  drivers/net/nfp/flower/nfp_flower.c           |  56 +--
> >  drivers/net/nfp/flower/nfp_flower_ctrl.c      |  20 +-
> >  drivers/net/nfp/flower/nfp_flower_ctrl.h      |   2 +-
> >  .../net/nfp/flower/nfp_flower_representor.c   |   7 +
> >  drivers/net/nfp/flower/nfp_flower_service.c   | 196 +++++++++
> >  drivers/net/nfp/flower/nfp_flower_service.h   |  17 +
> >  drivers/net/nfp/meson.build                   |   3 +
> >  drivers/net/nfp/nfp_cpp_bridge.c              |  91 +----
> >  drivers/net/nfp/nfp_cpp_bridge.h              |   1 -
> >  drivers/net/nfp/nfp_ethdev.c                  |  31 +-
> >  drivers/net/nfp/nfp_net_common.h              |  15 +-
> >  drivers/net/nfp/nfp_service.c                 | 117 ++++++
> >  drivers/net/nfp/nfp_service.h                 |  20 +
> >  drivers/net/nfp/nfpcore/nfp_sync.c            | 382 ++++++++++++++++++
> >  drivers/net/nfp/nfpcore/nfp_sync.h            |  31 ++
> >  15 files changed, 854 insertions(+), 135 deletions(-)  create mode
> > 100644 drivers/net/nfp/flower/nfp_flower_service.c
> >  create mode 100644 drivers/net/nfp/flower/nfp_flower_service.h
> >  create mode 100644 drivers/net/nfp/nfp_service.c  create mode 100644
> > drivers/net/nfp/nfp_service.h  create mode 100644
> > drivers/net/nfp/nfpcore/nfp_sync.c
> >  create mode 100644 drivers/net/nfp/nfpcore/nfp_sync.h
> >
  
Ferruh Yigit Feb. 8, 2024, 1:58 p.m. UTC | #3
On 2/2/2024 3:04 AM, Chaoyong He wrote:
> Make multiple devices can use single core to run services for
> flower firmware.
> Also add synchronize module and service module to support it.
> 
> ---
> v2:
> * Merge the last commit of v1 into the second commit.
> ---
> 
> Long Wu (3):
>   net/nfp: add synchronize module
>   net/nfp: create new service code related files
>   net/nfp: flower driver uses one service core
>

Series applied to dpdk-next-net/main, thanks.