mbox series

[v8,0/7] dts: Port scatter suite over

Message ID 20240110144249.20719-1-jspewock@iol.unh.edu (mailing list archive)
Headers
Series dts: Port scatter suite over |

Message

Jeremy Spewock Jan. 10, 2024, 2:42 p.m. UTC 
  From: Jeremy Spewock <jspewock@iol.unh.edu>

v8:

Address comments by making minor docstring adjustments.

Jeremy Spewock (7):
  dts: add startup verification and forwarding modes to testpmd shell
  dts: limit EAL parameters to DPDK apps and add parameters to all apps
  dts: add optional packet filtering to scapy sniffer
  dts: add pci addresses to EAL parameters
  dts: allow configuring MTU of ports
  dts: add scatter to the yaml schema
  dts: add pmd_buffer_scatter test suite

 dts/framework/config/conf_yaml_schema.json    |   3 +-
 dts/framework/exception.py                    |   7 +
 dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
 dts/framework/test_suite.py                   |  15 +-
 dts/framework/testbed_model/linux_session.py  |   8 +
 dts/framework/testbed_model/os_session.py     |   9 ++
 dts/framework/testbed_model/sut_node.py       |  28 +++-
 dts/framework/testbed_model/tg_node.py        |  14 +-
 .../traffic_generator/__init__.py             |   7 +-
 .../capturing_traffic_generator.py            |  22 ++-
 .../testbed_model/traffic_generator/scapy.py  |  27 ++++
 dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
 12 files changed, 407 insertions(+), 14 deletions(-)
 create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py

Comments

Juraj Linkeš Jan. 11, 2024, 10:07 a.m. UTC | #1 
Luca, Yoan or Paul, could please have a look at this patch? I don't
have any more comments, but I'd like to have someone else have a look
at this.

For the whole series:
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

On Wed, Jan 10, 2024 at 3:43 PM <jspewock@iol.unh.edu> wrote:
>
> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> v8:
>
> Address comments by making minor docstring adjustments.
>
> Jeremy Spewock (7):
>   dts: add startup verification and forwarding modes to testpmd shell
>   dts: limit EAL parameters to DPDK apps and add parameters to all apps
>   dts: add optional packet filtering to scapy sniffer
>   dts: add pci addresses to EAL parameters
>   dts: allow configuring MTU of ports
>   dts: add scatter to the yaml schema
>   dts: add pmd_buffer_scatter test suite
>
>  dts/framework/config/conf_yaml_schema.json    |   3 +-
>  dts/framework/exception.py                    |   7 +
>  dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
>  dts/framework/test_suite.py                   |  15 +-
>  dts/framework/testbed_model/linux_session.py  |   8 +
>  dts/framework/testbed_model/os_session.py     |   9 ++
>  dts/framework/testbed_model/sut_node.py       |  28 +++-
>  dts/framework/testbed_model/tg_node.py        |  14 +-
>  .../traffic_generator/__init__.py             |   7 +-
>  .../capturing_traffic_generator.py            |  22 ++-
>  .../testbed_model/traffic_generator/scapy.py  |  27 ++++
>  dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
>  12 files changed, 407 insertions(+), 14 deletions(-)
>  create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py
>
> --
> 2.43.0
>
Patrick Robb Feb. 21, 2024, 3:34 a.m. UTC | #2 
Tested-by: Patrick Robb <probb@iol.unh.edu>

I ran this testsuite with a bnxt_en NIC at the Community Lab.

I also spoke with Jeremy about the state of this patch today. He wants to
add a second testcase to the suite for testing the scattered packets
hardware offload (--enable-scatter flag in testpmd). But, he still has
questions about querying ethdev for capabilities and writing the testcase
around that, so that testcase cannot be submitted for this release. It will
come in as a separate patch.

So, from what I can tell Juraj has completed his review and this is the
final v of this patchseries.

On Wed, Jan 10, 2024 at 9:43 AM <jspewock@iol.unh.edu> wrote:

> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> v8:
>
> Address comments by making minor docstring adjustments.
>
> Jeremy Spewock (7):
>   dts: add startup verification and forwarding modes to testpmd shell
>   dts: limit EAL parameters to DPDK apps and add parameters to all apps
>   dts: add optional packet filtering to scapy sniffer
>   dts: add pci addresses to EAL parameters
>   dts: allow configuring MTU of ports
>   dts: add scatter to the yaml schema
>   dts: add pmd_buffer_scatter test suite
>
>  dts/framework/config/conf_yaml_schema.json    |   3 +-
>  dts/framework/exception.py                    |   7 +
>  dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
>  dts/framework/test_suite.py                   |  15 +-
>  dts/framework/testbed_model/linux_session.py  |   8 +
>  dts/framework/testbed_model/os_session.py     |   9 ++
>  dts/framework/testbed_model/sut_node.py       |  28 +++-
>  dts/framework/testbed_model/tg_node.py        |  14 +-
>  .../traffic_generator/__init__.py             |   7 +-
>  .../capturing_traffic_generator.py            |  22 ++-
>  .../testbed_model/traffic_generator/scapy.py  |  27 ++++
>  dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
>  12 files changed, 407 insertions(+), 14 deletions(-)
>  create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py
>
> --
> 2.43.0
>
>
Thomas Monjalon March 7, 2024, 3 p.m. UTC | #3 
10/01/2024 15:42, jspewock@iol.unh.edu:
>  dts/framework/config/conf_yaml_schema.json    |   3 +-
>  dts/framework/exception.py                    |   7 +
>  dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
>  dts/framework/test_suite.py                   |  15 +-
>  dts/framework/testbed_model/linux_session.py  |   8 +
>  dts/framework/testbed_model/os_session.py     |   9 ++
>  dts/framework/testbed_model/sut_node.py       |  28 +++-
>  dts/framework/testbed_model/tg_node.py        |  14 +-
>  .../traffic_generator/__init__.py             |   7 +-
>  .../capturing_traffic_generator.py            |  22 ++-
>  .../testbed_model/traffic_generator/scapy.py  |  27 ++++
>  dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
>  12 files changed, 407 insertions(+), 14 deletions(-)
>  create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py

Big refactoring was done in other patch series by Juraj.
Please could you check whether a rebase is needed for this series?
Jeremy Spewock March 11, 2024, 2:15 p.m. UTC | #4 
On Thu, Mar 7, 2024 at 10:00 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 10/01/2024 15:42, jspewock@iol.unh.edu:
> >  dts/framework/config/conf_yaml_schema.json    |   3 +-
> >  dts/framework/exception.py                    |   7 +
> >  dts/framework/remote_session/testpmd_shell.py | 149 +++++++++++++++++-
> >  dts/framework/test_suite.py                   |  15 +-
> >  dts/framework/testbed_model/linux_session.py  |   8 +
> >  dts/framework/testbed_model/os_session.py     |   9 ++
> >  dts/framework/testbed_model/sut_node.py       |  28 +++-
> >  dts/framework/testbed_model/tg_node.py        |  14 +-
> >  .../traffic_generator/__init__.py             |   7 +-
> >  .../capturing_traffic_generator.py            |  22 ++-
> >  .../testbed_model/traffic_generator/scapy.py  |  27 ++++
> >  dts/tests/TestSuite_pmd_buffer_scatter.py     | 132 ++++++++++++++++
> >  12 files changed, 407 insertions(+), 14 deletions(-)
> >  create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py
>
> Big refactoring was done in other patch series by Juraj.
> Please could you check whether a rebase is needed for this series?
>
This series does need a rebase but it looks like it was a clean one.
I'll rebase and give it one more quick test run and then send out the
new version.