[v3,0/4] net/hns3: refactor mailbox

Message ID 20231207013732.3987482-1-haijie1@huawei.com (mailing list archive)
Headers
Series net/hns3: refactor mailbox |

Message

Jie Hai Dec. 7, 2023, 1:37 a.m. UTC
  This patchset refactors mailbox codes.

--
v3:
1. fix the checkpatch warning on __atomic_xxx.
--

Dengdui Huang (4):
  net/hns3: refactor VF mailbox message struct
  net/hns3: refactor PF mailbox message struct
  net/hns3: refactor send mailbox function
  net/hns3: refactor handle mailbox function

 drivers/net/hns3/hns3_ethdev.c    |   2 +-
 drivers/net/hns3/hns3_ethdev.h    |   2 +-
 drivers/net/hns3/hns3_ethdev_vf.c | 181 +++++++++++++++++-------------
 drivers/net/hns3/hns3_mbx.c       | 166 +++++++++++++++------------
 drivers/net/hns3/hns3_mbx.h       |  94 ++++++++++++----
 drivers/net/hns3/hns3_rxtx.c      |  18 ++-
 6 files changed, 280 insertions(+), 183 deletions(-)
  

Comments

Ferruh Yigit Dec. 7, 2023, 12:31 p.m. UTC | #1
On 12/7/2023 1:37 AM, Jie Hai wrote:
> This patchset refactors mailbox codes.
> 
> --
> v3:
> 1. fix the checkpatch warning on __atomic_xxx.
> --
> 
> Dengdui Huang (4):
>   net/hns3: refactor VF mailbox message struct
>   net/hns3: refactor PF mailbox message struct
>   net/hns3: refactor send mailbox function
>   net/hns3: refactor handle mailbox function
> 
>  

Hi Jie, Dengdui,

Set fails to build with clang and stdatomic [1], it can be reproduced
with command [2]. Can you please check?

[1]
https://mails.dpdk.org/archives/test-report/2023-December/525771.html

[2]
CC=clang meson setup --buildtype=debugoptimized --werror
-Denable_stdatomic=true build && ninja -C build
  
Jie Hai Dec. 8, 2023, 1:06 a.m. UTC | #2
On 2023/12/7 20:31, Ferruh Yigit wrote:
> On 12/7/2023 1:37 AM, Jie Hai wrote:
>> This patchset refactors mailbox codes.
>>
>> --
>> v3:
>> 1. fix the checkpatch warning on __atomic_xxx.
>> --
>>
>> Dengdui Huang (4):
>>    net/hns3: refactor VF mailbox message struct
>>    net/hns3: refactor PF mailbox message struct
>>    net/hns3: refactor send mailbox function
>>    net/hns3: refactor handle mailbox function
>>
>>   
> 
> Hi Jie, Dengdui,
> 
> Set fails to build with clang and stdatomic [1], it can be reproduced
> with command [2]. Can you please check?
> 
> [1]
> https://mails.dpdk.org/archives/test-report/2023-December/525771.html
> 
> [2]
> CC=clang meson setup --buildtype=debugoptimized --werror
> -Denable_stdatomic=true build && ninja -C build
> .
Hi, Ferruh,

Thanks, I'will check and fix it.

Best regards,
Jie Hai