| Message ID | 20231127141659.46600-1-lihuisong@huawei.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF41D433E5; Mon, 27 Nov 2023 15:17:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52617402A3; Mon, 27 Nov 2023 15:17:02 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id B8E1E4014F for <dev@dpdk.org>; Mon, 27 Nov 2023 15:16:59 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Sf6x34WNnzSgyT; Mon, 27 Nov 2023 22:12:39 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 27 Nov 2023 22:16:57 +0800 From: Huisong Li <lihuisong@huawei.com> To: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net> CC: <liuyonglong@huawei.com>, <lihuisong@huawei.com> Subject: [PATCH v4 0/5] doc/features: fix some features and add new features Date: Mon, 27 Nov 2023 22:16:54 +0800 Message-ID: <20231127141659.46600-1-lihuisong@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231123135916.33315-1-lihuisong@huawei.com> References: <20231123135916.33315-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
doc/features: fix some features and add new features
|
|
Message
lihuisong (C)
Nov. 27, 2023, 2:16 p.m. UTC
The support for setting RSS hash algorithm has been introduced to 23.11, but doesn't add feature for it. So this series add this feature to RSS hash and perfect RSS other features by the way. In addition, serval features or interface, like "set link up/down", "TM", "link speeds" and "dump device private information" had beed supported, but they are absent from the freatures list. --- -v4: - fix RSS releated feaures description based on Ferruh - add new features to default.ini - remove loopback patch. - move "dump device private information" to "dev ops" block. -v3: - fix description of the patchset cover - remove '/features' in 'doc/features' tag for every patch. - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> - retrigger CI build because of wrong CI warning -v2: - add loopback mode feature. Huisong Li (5): doc: fix the description of RSS related feature doc: add link up/down feature doc: add features for link speeds doc: add Traffic Manager feature doc: add dump device private information ops doc/guides/nics/features.rst | 47 +++++++++++++++++++++++++--- doc/guides/nics/features/default.ini | 2 ++ 2 files changed, 45 insertions(+), 4 deletions(-)
Comments
On 11/27/2023 2:16 PM, Huisong Li wrote: > The support for setting RSS hash algorithm has been introduced to 23.11, > but doesn't add feature for it. So this series add this feature to RSS hash > and perfect RSS other features by the way. > > In addition, serval features or interface, like "set link up/down", "TM", > "link speeds" and "dump device private information" had beed supported, > but they are absent from the freatures list. > > --- > -v4: > - fix RSS releated feaures description based on Ferruh > - add new features to default.ini > - remove loopback patch. > - move "dump device private information" to "dev ops" block. > > -v3: > - fix description of the patchset cover > - remove '/features' in 'doc/features' tag for every patch. > - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> > - retrigger CI build because of wrong CI warning > > -v2: > - add loopback mode feature. > > Huisong Li (5): > doc: fix the description of RSS related feature > doc: add link up/down feature > doc: add features for link speeds > doc: add Traffic Manager feature > doc: add dump device private information ops > As mentioned before I don't know about adding link speed feature or not, would like to get more comment. But for the new features added, driver .ini files also needs to be updated for that new feature, and drivers support it should mark the support. That is why it is best to start documenting a feature when it is first introduced, otherwise it is more work to update it later.
On 11/27/2023 2:16 PM, Huisong Li wrote: > The support for setting RSS hash algorithm has been introduced to 23.11, > but doesn't add feature for it. So this series add this feature to RSS hash > and perfect RSS other features by the way. > > In addition, serval features or interface, like "set link up/down", "TM", > "link speeds" and "dump device private information" had beed supported, > but they are absent from the freatures list. > > --- > -v4: > - fix RSS releated feaures description based on Ferruh > - add new features to default.ini > - remove loopback patch. > - move "dump device private information" to "dev ops" block. > > -v3: > - fix description of the patchset cover > - remove '/features' in 'doc/features' tag for every patch. > - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> > - retrigger CI build because of wrong CI warning > > -v2: > - add loopback mode feature. > > Huisong Li (5): > doc: fix the description of RSS related feature > doc: add link up/down feature > doc: add features for link speeds > doc: add Traffic Manager feature > doc: add dump device private information ops > Please check the warning on document generation: https://mails.dpdk.org/archives/test-report/2023-November/519586.html /home/runner/work/dpdk/dpdk/doc/guides/nics/features.rst:307:Unexpected indentation.
在 2023/11/28 0:44, Ferruh Yigit 写道: > On 11/27/2023 2:16 PM, Huisong Li wrote: >> The support for setting RSS hash algorithm has been introduced to 23.11, >> but doesn't add feature for it. So this series add this feature to RSS hash >> and perfect RSS other features by the way. >> >> In addition, serval features or interface, like "set link up/down", "TM", >> "link speeds" and "dump device private information" had beed supported, >> but they are absent from the freatures list. >> >> --- >> -v4: >> - fix RSS releated feaures description based on Ferruh >> - add new features to default.ini >> - remove loopback patch. >> - move "dump device private information" to "dev ops" block. >> >> -v3: >> - fix description of the patchset cover >> - remove '/features' in 'doc/features' tag for every patch. >> - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> >> - retrigger CI build because of wrong CI warning >> >> -v2: >> - add loopback mode feature. >> >> Huisong Li (5): >> doc: fix the description of RSS related feature >> doc: add link up/down feature >> doc: add features for link speeds >> doc: add Traffic Manager feature >> doc: add dump device private information ops >> > As mentioned before I don't know about adding link speed feature or not, > would like to get more comment. ok, let us to get more comment. it is better that we send a separated patch about link speed feature to discuss and get more comment. In this way, other patch in this series also go ahead to upload. what do you think? > > But for the new features added, driver .ini files also needs to be > updated for that new feature, and drivers support it should mark the > support. agree. I will add "Traffic Manager" feature to driver.ini for the supported TM driver. But I'm not sure if I am supposed to do this in patch 4/5 or send independent patch for every supported driver. what do you think of that? > That is why it is best to start documenting a feature when it is first > introduced, otherwise it is more work to update it later. agree with you. we should remind someone to add it to this feature doc when a new feature is introduced. > > .
在 2023/11/28 0:56, Ferruh Yigit 写道: > On 11/27/2023 2:16 PM, Huisong Li wrote: >> The support for setting RSS hash algorithm has been introduced to 23.11, >> but doesn't add feature for it. So this series add this feature to RSS hash >> and perfect RSS other features by the way. >> >> In addition, serval features or interface, like "set link up/down", "TM", >> "link speeds" and "dump device private information" had beed supported, >> but they are absent from the freatures list. >> >> --- >> -v4: >> - fix RSS releated feaures description based on Ferruh >> - add new features to default.ini >> - remove loopback patch. >> - move "dump device private information" to "dev ops" block. >> >> -v3: >> - fix description of the patchset cover >> - remove '/features' in 'doc/features' tag for every patch. >> - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> >> - retrigger CI build because of wrong CI warning >> >> -v2: >> - add loopback mode feature. >> >> Huisong Li (5): >> doc: fix the description of RSS related feature >> doc: add link up/down feature >> doc: add features for link speeds >> doc: add Traffic Manager feature >> doc: add dump device private information ops >> > Please check the warning on document generation: > https://mails.dpdk.org/archives/test-report/2023-November/519586.html > > /home/runner/work/dpdk/dpdk/doc/guides/nics/features.rst:307:Unexpected > indentation. Here has a format issue. I will fix it next version. Thanks. > > .
在 2023/11/28 10:09, lihuisong (C) 写道: > > 在 2023/11/28 0:44, Ferruh Yigit 写道: >> On 11/27/2023 2:16 PM, Huisong Li wrote: >>> The support for setting RSS hash algorithm has been introduced to >>> 23.11, >>> but doesn't add feature for it. So this series add this feature to >>> RSS hash >>> and perfect RSS other features by the way. >>> >>> In addition, serval features or interface, like "set link up/down", >>> "TM", >>> "link speeds" and "dump device private information" had beed supported, >>> but they are absent from the freatures list. >>> >>> --- >>> -v4: >>> - fix RSS releated feaures description based on Ferruh >>> - add new features to default.ini >>> - remove loopback patch. >>> - move "dump device private information" to "dev ops" block. >>> >>> -v3: >>> - fix description of the patchset cover >>> - remove '/features' in 'doc/features' tag for every patch. >>> - add Acked-by: Chengwen Feng <fengchengwen@huawei.com> >>> - retrigger CI build because of wrong CI warning >>> >>> -v2: >>> - add loopback mode feature. >>> >>> Huisong Li (5): >>> doc: fix the description of RSS related feature >>> doc: add link up/down feature >>> doc: add features for link speeds >>> doc: add Traffic Manager feature >>> doc: add dump device private information ops >>> >> As mentioned before I don't know about adding link speed feature or not, >> would like to get more comment. > ok, let us to get more comment. > it is better that we send a separated patch about link speed feature > to discuss and get more comment. > In this way, other patch in this series also go ahead to upload. > what do you think? >> >> But for the new features added, driver .ini files also needs to be >> updated for that new feature, and drivers support it should mark the >> support. > agree. > I will add "Traffic Manager" feature to driver.ini for the supported > TM driver. > But I'm not sure if I am supposed to do this in patch 4/5 or send > independent patch for every supported driver. Thinking twice, I will separate this "TM" patch from this series and send a independent patchset to do this. Then we can take a look at that series. > what do you think of that? >> That is why it is best to start documenting a feature when it is first >> introduced, otherwise it is more work to update it later. > agree with you. > we should remind someone to add it to this feature doc when a new > feature is introduced. >> >> . > .