[v3,0/7] dts: Port scatter suite over

Message ID 20231113202833.12900-1-jspewock@iol.unh.edu (mailing list archive)
Headers
Series dts: Port scatter suite over |

Message

Jeremy Spewock Nov. 13, 2023, 8:28 p.m. UTC
  From: Jeremy Spewock <jspewock@iol.unh.edu>

The only thing this version changes is it fixes typos in the commit
messages so it will pass checkpatch.

Depends-on: series-30231 ("dts: Add the ability to bind ports to drivers")

Jeremy Spewock (7):
  dts: Add scatter test suite
  dts: add waiting for port up in testpmd
  dts: add scatter to the yaml schema
  dts: allow passing parameters into interactive apps
  dts: add optional packet filtering to scapy sniffer
  dts: add pci addresses to EAL parameters
  dts: allow configuring MTU of ports

 dts/framework/config/conf_yaml_schema.json    |  3 +-
 dts/framework/remote_session/linux_session.py |  7 ++
 dts/framework/remote_session/os_session.py    |  9 ++
 .../remote_session/remote/testpmd_shell.py    | 31 ++++++-
 dts/framework/test_suite.py                   | 13 ++-
 .../capturing_traffic_generator.py            | 12 ++-
 dts/framework/testbed_model/scapy.py          | 11 ++-
 dts/framework/testbed_model/sut_node.py       | 20 ++++-
 dts/framework/testbed_model/tg_node.py        |  4 +-
 dts/tests/TestSuite_scatter.py                | 86 +++++++++++++++++++
 10 files changed, 185 insertions(+), 11 deletions(-)
 create mode 100644 dts/tests/TestSuite_scatter.py
  

Comments

Juraj Linkeš Nov. 16, 2023, 7:23 p.m. UTC | #1
On Mon, Nov 13, 2023 at 9:28 PM <jspewock@iol.unh.edu> wrote:
>
> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> The only thing this version changes is it fixes typos in the commit
> messages so it will pass checkpatch.
>
> Depends-on: series-30231 ("dts: Add the ability to bind ports to drivers")
>
> Jeremy Spewock (7):
>   dts: Add scatter test suite
>   dts: add waiting for port up in testpmd
>   dts: add scatter to the yaml schema
>   dts: allow passing parameters into interactive apps
>   dts: add optional packet filtering to scapy sniffer
>   dts: add pci addresses to EAL parameters
>   dts: allow configuring MTU of ports
>

Just a note: I reviewed this in the reverse order, since the test
suite should be last, as it uses the rest of the code. Ideally, the
commits should not break anything when applied in order (i.e. after
applying the first patch, there should be no regressions and so on).

>  dts/framework/config/conf_yaml_schema.json    |  3 +-
>  dts/framework/remote_session/linux_session.py |  7 ++
>  dts/framework/remote_session/os_session.py    |  9 ++
>  .../remote_session/remote/testpmd_shell.py    | 31 ++++++-
>  dts/framework/test_suite.py                   | 13 ++-
>  .../capturing_traffic_generator.py            | 12 ++-
>  dts/framework/testbed_model/scapy.py          | 11 ++-
>  dts/framework/testbed_model/sut_node.py       | 20 ++++-
>  dts/framework/testbed_model/tg_node.py        |  4 +-
>  dts/tests/TestSuite_scatter.py                | 86 +++++++++++++++++++
>  10 files changed, 185 insertions(+), 11 deletions(-)
>  create mode 100644 dts/tests/TestSuite_scatter.py
>
> --
> 2.42.0
>
  
Jeremy Spewock Dec. 18, 2023, 5:22 p.m. UTC | #2
From: Jeremy Spewock <jspewock@iol.unh.edu>

v4:

Addresses comments on the previous version. Main things which were added
include specific methods within the testpmd shell to avoid the need of
calling send_command directly, as well as docstring comment updates.

This series had to get resubmitted so that it would show up as one
series on patchwork. Previously each patch was given its own series by
mistake. Seeing as there was no change otherwise, submitting this as v4
once again.

Jeremy Spewock (7):
  dts: add required methods to testpmd_shell
  dts: allow passing parameters into interactive apps
  dts: add optional packet filtering to scapy sniffer
  dts: add pci addresses to EAL parameters
  dts: allow configuring MTU of ports
  dts: add scatter to the yaml schema
  dts: add scatter test suite

 dts/framework/config/conf_yaml_schema.json    |   3 +-
 dts/framework/exception.py                    |   4 +
 dts/framework/remote_session/linux_session.py |   8 ++
 dts/framework/remote_session/os_session.py    |   9 ++
 .../remote_session/remote/testpmd_shell.py    |  94 +++++++++++++++-
 dts/framework/test_suite.py                   |  14 ++-
 .../capturing_traffic_generator.py            |  22 +++-
 dts/framework/testbed_model/scapy.py          |  28 ++++-
 dts/framework/testbed_model/sut_node.py       |  27 ++++-
 dts/framework/testbed_model/tg_node.py        |  12 +-
 dts/tests/TestSuite_pmd_buffer_scatter.py     | 105 ++++++++++++++++++
 11 files changed, 312 insertions(+), 14 deletions(-)
 create mode 100644 dts/tests/TestSuite_pmd_buffer_scatter.py