mbox series

[v2,0/6] net/hns3: fix and refactor some codes

Message ID 20231110061331.3670158-1-haijie1@huawei.com (mailing list archive)
Headers
Series net/hns3: fix and refactor some codes |

Message

Jie Hai Nov. 10, 2023, 6:13 a.m. UTC 
  This patchset fixes the failure on sync mailbox and
refactors some codes on mailbox, also replace gcc
builtin __atomic_xxx with rte_atomic_xxx.

--
v2:
1. fix misspelling error in commit log and codes.
2. replace __atomic_xxx with rte_atomic_xxx.

--

Dengdui Huang (5):
  net/hns3: fix sync mailbox failure forever
  net/hns3: refactor VF mailbox message struct
  net/hns3: refactor PF mailbox message struct
  net/hns3: refactor send mailbox function
  net/hns3: refactor handle mailbox function

Jie Hai (1):
  net/hns3: use stdatomic API

 drivers/net/hns3/hns3_cmd.c       |  25 +--
 drivers/net/hns3/hns3_dcb.c       |   3 +-
 drivers/net/hns3/hns3_ethdev.c    |  53 ++++---
 drivers/net/hns3/hns3_ethdev.h    |  12 +-
 drivers/net/hns3/hns3_ethdev_vf.c | 237 +++++++++++++++-------------
 drivers/net/hns3/hns3_intr.c      |  39 +++--
 drivers/net/hns3/hns3_mbx.c       | 251 +++++++++++++-----------------
 drivers/net/hns3/hns3_mbx.h       | 104 +++++++++----
 drivers/net/hns3/hns3_mp.c        |   9 +-
 drivers/net/hns3/hns3_rxtx.c      |  33 ++--
 drivers/net/hns3/hns3_tm.c        |   6 +-
 11 files changed, 421 insertions(+), 351 deletions(-)

Comments

Ferruh Yigit Nov. 10, 2023, 4:12 p.m. UTC | #1 
On 11/10/2023 6:13 AM, Jie Hai wrote:
> This patchset fixes the failure on sync mailbox and
> refactors some codes on mailbox, also replace gcc
> builtin __atomic_xxx with rte_atomic_xxx.
> 
> --
> v2:
> 1. fix misspelling error in commit log and codes.
> 2. replace __atomic_xxx with rte_atomic_xxx.
> 
> --
> 
> Dengdui Huang (5):
>   net/hns3: fix sync mailbox failure forever
>   net/hns3: refactor VF mailbox message struct
>   net/hns3: refactor PF mailbox message struct
>   net/hns3: refactor send mailbox function
>   net/hns3: refactor handle mailbox function
> 
> Jie Hai (1):
>   net/hns3: use stdatomic API
> 

Hi Jie,

I still believe this set is a big update for -rc3, I proceeded based on
your request with the ask to test it thoroughly, but new version doesn't
even compiles, which doesn't gives confidence about the set.

As most of the code is refactoring, lets postpone it to next release.

Please send the fix, first patch, as separate patch and only merge that
one for this release.