mbox series

[0/2] net/mlx5: fix flow rules for external SQ

Message ID 20231109085547.1313003-1-suanmingm@nvidia.com (mailing list archive)
Headers
Series net/mlx5: fix flow rules for external SQ |

Message

Suanming Mou Nov. 9, 2023, 8:55 a.m. UTC 
  If representor matching was enabled (device argument repr_matching_en
is equal to 1, default configuration), then during registration of
external SQs, mlx5 PMD would not create control flow rules in NIC Tx
domain. This caused an issue with packet metadata. If a packet sent
on external SQ had packet metadata attached, then it would be lost
when it would go from NIC Tx to FDB domain.

Meanwhile, the external SQ flow rules should be managed individually
and not be destroyed internally by PMD.

This series fixes these two issues for the external SQ flow rules in
rte_pmd_mlx5_external_sq_enable().

Dariusz Sosnowski (1):
  net/mlx5: fix missing flow rules for external SQ

Suanming Mou (1):
  net/mlx5: fix destroying external representor matched flows

 drivers/net/mlx5/mlx5.h         |  41 ++++++++++
 drivers/net/mlx5/mlx5_flow.h    |   6 +-
 drivers/net/mlx5/mlx5_flow_hw.c | 132 ++++++++++++++++++++++++++++----
 drivers/net/mlx5/mlx5_trigger.c |   4 +-
 drivers/net/mlx5/mlx5_txq.c     |  12 ++-
 5 files changed, 176 insertions(+), 19 deletions(-)

Comments

Raslan Darawsheh Nov. 12, 2023, 2:27 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Thursday, November 9, 2023 10:56 AM
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH 0/2] net/mlx5: fix flow rules for external SQ
> 
> If representor matching was enabled (device argument repr_matching_en is
> equal to 1, default configuration), then during registration of external SQs,
> mlx5 PMD would not create control flow rules in NIC Tx domain. This caused
> an issue with packet metadata. If a packet sent on external SQ had packet
> metadata attached, then it would be lost when it would go from NIC Tx to FDB
> domain.
> 
> Meanwhile, the external SQ flow rules should be managed individually and not
> be destroyed internally by PMD.
> 
> This series fixes these two issues for the external SQ flow rules in
> rte_pmd_mlx5_external_sq_enable().
> 
> Dariusz Sosnowski (1):
>   net/mlx5: fix missing flow rules for external SQ
> 
> Suanming Mou (1):
>   net/mlx5: fix destroying external representor matched flows
> 
>  drivers/net/mlx5/mlx5.h         |  41 ++++++++++
>  drivers/net/mlx5/mlx5_flow.h    |   6 +-
>  drivers/net/mlx5/mlx5_flow_hw.c | 132
> ++++++++++++++++++++++++++++----
>  drivers/net/mlx5/mlx5_trigger.c |   4 +-
>  drivers/net/mlx5/mlx5_txq.c     |  12 ++-
>  5 files changed, 176 insertions(+), 19 deletions(-)
> 
> --
> 2.34.1

Fixed a typo in the first commit, and fixed a warning for a line too long
Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh