| Message ID | 20231108034434.559030-1-haijie1@huawei.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06D9C432CE; Wed, 8 Nov 2023 04:48:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C128A42DC7; Wed, 8 Nov 2023 04:48:52 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 5C73A42DD9 for <dev@dpdk.org>; Wed, 8 Nov 2023 04:48:49 +0100 (CET) Received: from kwepemd100004.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SQ9zq1JzQzfb1P for <dev@dpdk.org>; Wed, 8 Nov 2023 11:48:39 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.23; Wed, 8 Nov 2023 11:48:14 +0800 From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org> Subject: [PATCH 0/5] net/hns3: fix and refactor mailbox code Date: Wed, 8 Nov 2023 11:44:29 +0800 Message-ID: <20231108034434.559030-1-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd100004.china.huawei.com (7.221.188.31) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series | net/hns3: fix and refactor mailbox code | |
Message
Jie Hai
Nov. 8, 2023, 3:44 a.m. UTC
This patchset fixes failure on sync mailbox and refactors some codes on mailbox. Dengdui Huang (5): net/hns3: fix sync mailbox failure forever net/hns3: refactor VF mailbox message struct net/hns3: refactor PF mailbox message struct net/hns3: refactor send mailbox function net/hns3: refactor handle mailbox function drivers/net/hns3/hns3_cmd.c | 3 - drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 181 ++++++++++++---------- drivers/net/hns3/hns3_mbx.c | 244 +++++++++++++----------------- drivers/net/hns3/hns3_mbx.h | 104 +++++++++---- drivers/net/hns3/hns3_rxtx.c | 18 +-- 6 files changed, 290 insertions(+), 262 deletions(-)
Comments
On 11/8/2023 3:44 AM, Jie Hai wrote: > This patchset fixes failure on sync mailbox and refactors some codes on mailbox. > > Dengdui Huang (5): > net/hns3: fix sync mailbox failure forever > net/hns3: refactor VF mailbox message struct > net/hns3: refactor PF mailbox message struct > net/hns3: refactor send mailbox function > net/hns3: refactor handle mailbox function > Hi Jie, Overall patchset looks good with minor issue below [1], but this set has high impact and not solving a critical defect etc, but mainly refactoring. We are very close to the release, there won't be enough time to fix any issue caused by this refactoring. My suggestion is to postpone the refactoring to next release, maybe get only the first fix patch in this release, what do you think? [1] Can you please fix the checkpatch warning: ### [PATCH] net/hns3: refactor handle mailbox function Warning in drivers/net/hns3/hns3_mbx.c: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx
On 2023/11/10 2:50, Ferruh Yigit wrote: > On 11/8/2023 3:44 AM, Jie Hai wrote: >> This patchset fixes failure on sync mailbox and refactors some codes on mailbox. >> >> Dengdui Huang (5): >> net/hns3: fix sync mailbox failure forever >> net/hns3: refactor VF mailbox message struct >> net/hns3: refactor PF mailbox message struct >> net/hns3: refactor send mailbox function >> net/hns3: refactor handle mailbox function >> > > Hi Jie, > > Overall patchset looks good with minor issue below [1], but this set has > high impact and not solving a critical defect etc, but mainly refactoring. > We are very close to the release, there won't be enough time to fix any > issue caused by this refactoring. > > My suggestion is to postpone the refactoring to next release, maybe get > only the first fix patch in this release, what do you think? > I think it's OK. > > > [1] > Can you please fix the checkpatch warning: > > ### [PATCH] net/hns3: refactor handle mailbox function > > Warning in drivers/net/hns3/hns3_mbx.c: > Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer > rte_atomic_xxx/rte_memory_order_xxx > Thanks, I'will send V2 with these fixes. > .
On 11/10/2023 6:21 AM, Jie Hai wrote: > On 2023/11/10 2:50, Ferruh Yigit wrote: >> On 11/8/2023 3:44 AM, Jie Hai wrote: >>> This patchset fixes failure on sync mailbox and refactors some codes >>> on mailbox. >>> >>> Dengdui Huang (5): >>> net/hns3: fix sync mailbox failure forever >>> net/hns3: refactor VF mailbox message struct >>> net/hns3: refactor PF mailbox message struct >>> net/hns3: refactor send mailbox function >>> net/hns3: refactor handle mailbox function >>> >> >> Hi Jie, >> >> Overall patchset looks good with minor issue below [1], but this set has >> high impact and not solving a critical defect etc, but mainly >> refactoring. >> We are very close to the release, there won't be enough time to fix any >> issue caused by this refactoring. >> >> My suggestion is to postpone the refactoring to next release, maybe get >> only the first fix patch in this release, what do you think? >> > I think it's OK. > OK, I will proceed with it, please be sure it is fully verified. >> >> >> [1] >> Can you please fix the checkpatch warning: >> >> ### [PATCH] net/hns3: refactor handle mailbox function >> >> Warning in drivers/net/hns3/hns3_mbx.c: >> Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer >> rte_atomic_xxx/rte_memory_order_xxx >> > Thanks, I'will send V2 with these fixes. >> .