mbox series

[v4,0/6] Enhance the bond framework to support offload

Message ID 20231018074821.1908906-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series Enhance the bond framework to support offload |

Message

Chaoyong He Oct. 18, 2023, 7:48 a.m. UTC 
  This patch series try to enhance the bond framework to support the
offload feature better:
* Add new API to make the member port can access some information of the
  bond port which belongs.
* Add new API to get the result of whether bond port is created by the
  member port.
* Add two command line argument to control if enable member port
  notification and dedicated queue features.
* Add logic to support add ports which share the same PCI address into
  bond port.
* Also modify the testpmd application to test the new APIs and logics
  added by this patch series.

---
v2:
* Fix compile error on github-robot by removing the redundancy function
  declaration in the header file.
v3:
* Use the hole in the structure for the new added flag data field.
v4:
* Drop two commits not necessary for this series.
* Modify some logic as the review comments from reviewers.
---

Long Wu (6):
  ethdev: add member notification for bonding port
  ethdev: add API to get hardware creation of bonding port
  net/bonding: add bonding port arguments
  net/bonding: support add port by data name
  net/bonding: support checking valid bonding port ID
  net/bonding: add commands for bonding port notification

 .../link_bonding_poll_mode_drv_lib.rst        |  19 +++
 drivers/net/bonding/bonding_testpmd.c         | 128 ++++++++++++++++++
 drivers/net/bonding/eth_bond_private.h        |  11 ++
 drivers/net/bonding/rte_eth_bond.h            |  88 ++++++++++++
 drivers/net/bonding/rte_eth_bond_api.c        | 121 +++++++++++++++++
 drivers/net/bonding/rte_eth_bond_args.c       |  47 +++++++
 drivers/net/bonding/rte_eth_bond_pmd.c        |  93 ++++++++++++-
 drivers/net/bonding/version.map               |   5 +
 lib/ethdev/ethdev_driver.h                    |  38 ++++++
 9 files changed, 546 insertions(+), 4 deletions(-)

Comments

Ferruh Yigit Nov. 15, 2023, 4:01 p.m. UTC | #1 
On 10/18/2023 8:48 AM, Chaoyong He wrote:
> This patch series try to enhance the bond framework to support the
> offload feature better:
> * Add new API to make the member port can access some information of the
>   bond port which belongs.
> * Add new API to get the result of whether bond port is created by the
>   member port.
> * Add two command line argument to control if enable member port
>   notification and dedicated queue features.
> * Add logic to support add ports which share the same PCI address into
>   bond port.
> * Also modify the testpmd application to test the new APIs and logics
>   added by this patch series.
> 
> ---
> v2:
> * Fix compile error on github-robot by removing the redundancy function
>   declaration in the header file.
> v3:
> * Use the hole in the structure for the new added flag data field.
> v4:
> * Drop two commits not necessary for this series.
> * Modify some logic as the review comments from reviewers.
> ---
> 
> Long Wu (6):
>   ethdev: add member notification for bonding port
>   ethdev: add API to get hardware creation of bonding port
>   net/bonding: add bonding port arguments
>   net/bonding: support add port by data name
>   net/bonding: support checking valid bonding port ID
>   net/bonding: add commands for bonding port notification
> 
>  

Hi Chaoyong,

This patchset discussed in the technical board, to be able to discuss in
more details, can you please provide more details in the usecase?

Also there can be a gap on how to test this new additions, again knowing
the intended usecase may help.


There are a few things not ideal in the set, like adding bonding
specific APIs, ethdev additions specific to bonding, port not working on
generic capabilities/configuration approach but app needs to know that
it is bonding port etc ...

I will postpone the patchset to next release, please clarify more the
usecase and we can continue discussions.


Thanks,
ferruh
Chaoyong He Nov. 16, 2023, 1:45 a.m. UTC | #2 
> On 10/18/2023 8:48 AM, Chaoyong He wrote:
> > This patch series try to enhance the bond framework to support the
> > offload feature better:
> > * Add new API to make the member port can access some information of the
> >   bond port which belongs.
> > * Add new API to get the result of whether bond port is created by the
> >   member port.
> > * Add two command line argument to control if enable member port
> >   notification and dedicated queue features.
> > * Add logic to support add ports which share the same PCI address into
> >   bond port.
> > * Also modify the testpmd application to test the new APIs and logics
> >   added by this patch series.
> >
> > ---
> > v2:
> > * Fix compile error on github-robot by removing the redundancy function
> >   declaration in the header file.
> > v3:
> > * Use the hole in the structure for the new added flag data field.
> > v4:
> > * Drop two commits not necessary for this series.
> > * Modify some logic as the review comments from reviewers.
> > ---
> >
> > Long Wu (6):
> >   ethdev: add member notification for bonding port
> >   ethdev: add API to get hardware creation of bonding port
> >   net/bonding: add bonding port arguments
> >   net/bonding: support add port by data name
> >   net/bonding: support checking valid bonding port ID
> >   net/bonding: add commands for bonding port notification
> >
> >
> 
> Hi Chaoyong,
> 
> This patchset discussed in the technical board, to be able to discuss in more
> details, can you please provide more details in the usecase?
> 
> Also there can be a gap on how to test this new additions, again knowing the
> intended usecase may help.
> 
> 
> There are a few things not ideal in the set, like adding bonding specific APIs,
> ethdev additions specific to bonding, port not working on generic
> capabilities/configuration approach but app needs to know that it is bonding
> port etc ...
> 
> I will postpone the patchset to next release, please clarify more the usecase
> and we can continue discussions.
> 
> 
> Thanks,
> Ferruh

We will also send out the modifications of the NFP PMD as an usecase in the next release,
and I think that will provide some details for current problems.

Thanks.